Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for OIDC without the discovery endpoint #10613

Merged
merged 1 commit into from
Jul 10, 2020

Conversation

sberyozkin
Copy link
Member

We've had jwksPath and instrospectionPath properties since the very beginning but they've never worked and have only confused the users, due to the fact we have always relied on the auto-discovery

This PR:

  • introduces a discovery-enabled property (enabled by default)
  • if it is disabled - makes sure the minimum set of OIDC endpoint properties is set for web-app/service and initializes OAuth2Auth correctly
  • adds a test (relies on the test OidcResource which has a jwk endpoint)

CC @MarcusBiel

@sberyozkin sberyozkin added this to the 1.7.0 - master milestone Jul 9, 2020
@sberyozkin sberyozkin force-pushed the oidc_init_cleanup branch from ddbc736 to 4079fba Compare July 9, 2020 15:41
@sberyozkin sberyozkin force-pushed the oidc_init_cleanup branch from 4079fba to 46d7547 Compare July 9, 2020 22:23
@sberyozkin sberyozkin merged commit fb4c23d into quarkusio:master Jul 10, 2020
@sberyozkin sberyozkin deleted the oidc_init_cleanup branch September 16, 2020 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants