Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support @RepositoryDefinition for Spring Data repositories #10629

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Support @RepositoryDefinition for Spring Data repositories #10629

merged 1 commit into from
Jul 10, 2020

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jul 10, 2020

Fixes: #10614

@boring-cyborg boring-cyborg bot added area/hibernate-orm Hibernate ORM area/spring Issues relating to the Spring integration labels Jul 10, 2020
@geoand
Copy link
Contributor Author

geoand commented Jul 10, 2020

@gsmet although this isn't technically a bug fix, it is however really small and doesn't affect anything else so I would like to have it in 1.6.1.Final if possible :)

@geoand geoand removed the area/hibernate-orm Hibernate ORM label Jul 10, 2020
@geoand geoand mentioned this pull request Jul 10, 2020
Closed
gsmet
gsmet requested changes Jul 10, 2020
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a question, we need to clarify it before merging.

...nt/src/main/java/io/quarkus/spring/data/deployment/generate/SpringDataRepositoryCreator.java Outdated
.classAnnotation(DotNames.SPRING_DATA_REPOSITORY_DEFINITION);
if (repositoryDefinitionInstance != null) {
entityDotName = repositoryDefinitionInstance.value("domainClass").asClass().name();
idDotName = repositoryDefinitionInstance.value("idClass").asClass().name();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the place of this. If @RepositoryDefinition is used, can't we skip all the code above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are absolutely right! Fixed

@boring-cyborg boring-cyborg bot added the area/hibernate-orm Hibernate ORM label Jul 10, 2020
@geoand geoand requested a review from gsmet July 10, 2020 09:17
@gsmet gsmet merged commit 8cb97dc into quarkusio:master Jul 10, 2020
@gsmet gsmet added this to the 1.6.1.Final milestone Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/hibernate-orm Hibernate ORM area/spring Issues relating to the Spring integration
Projects
None yet
Milestone
1.6.1.Final
Development

Successfully merging this pull request may close these issues.

Quarkus extension for spring data API - automatic repository implementation generation
2 participants
@geoand @gsmet