Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reactive routes - add @Param, @Header and @Body #10630

Merged
merged 2 commits into from
Jul 13, 2020
Merged

Reactive routes - add @Param, @Header and @Body #10630

merged 2 commits into from
Jul 13, 2020

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jul 10, 2020

@mkouba mkouba requested a review from cescoffier July 10, 2020 08:00
@boring-cyborg boring-cyborg bot added area/arc Issue related to ARC (dependency injection) area/documentation area/vertx labels Jul 10, 2020
@mkouba mkouba added this to the 1.7.0 - master milestone Jul 10, 2020
@mkouba
Copy link
Contributor Author

mkouba commented Jul 10, 2020

Damn, I used mvn clean install -Dquickly and hence formatting errors..

@mkouba
Reactive routes - add @param, @Header and @Body
dfb7d46 
- refactor param injectors
- resolves quarkusio#10596
@cescoffier
Copy link
Member

cescoffier commented Jul 10, 2020 •
edited
Loading

Are path parameters supported? Should it use the same @Param annotation or a specific one?

cescoffier
cescoffier approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm wondering about path parameter.

@gastaldi
Copy link
Contributor

It looks like multiple parameters are not supported (eg. http://localhost:8080/foo?choice=1&choice=2).
Same for Header parameters : https://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.2

@mkouba
Copy link
Contributor Author

mkouba commented Jul 10, 2020

Are path parameters supported? Should it use the same @param annotation or a specific one?

@cescoffier They are supported. HttpServerRequest.getParam() returns both the path params and query params. I believe that it should use the same annotation.

It looks like multiple parameters are not supported

@gastaldi Yes, we always return the first value. But it should be easy to implement injection of List<String>. I'm on it...

@mkouba
Copy link
Contributor Author

mkouba commented Jul 10, 2020

@gastaldi Done ;-).

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 13, 2020
gastaldi
gastaldi approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job!

@mkouba mkouba merged commit e308276 into quarkusio:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) area/documentation area/vertx release/noteworthy-feature triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.7.0.CR1
Development

Successfully merging this pull request may close these issues.

Allow injecting parameters and body in reactive routes
3 participants
@mkouba @cescoffier @gastaldi