-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use JBoss Commons Logging Implementation - Amazon Alexa #10655
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: should we add the SLF4J connector too?
I would probably need help on what the JBoss Logging SL4J-impl is, as I had looked in the Maven Repo and couldn't find it (hence didn't add). My understanding is that SL4J will do "no-op" logging if an implementation is not found, though I suspect there may be some order preference being used, just like JBoss Logging does. |
All of these adapters should be added to the core IMO. It was just an error on my part that they were left off. But probably it should be |
I think I listed most of them here: https://github.com/quarkusio/quarkus/blob/master/docs/src/main/asciidoc/logging.adoc#logging-adapters . |
But yeah, either we add them when we exclude the implementation or we add them all to the core artifacts. |
22b7608
to
26216e9
Compare
Thanks! |
Enforce the use of the JBoss Apache Commons Logging Implementation by default for use with native image compilation of Amazon Alexa #10589, as explained in the documentation update #10474
The Amazon ASK SDK v2 uses Commons Logging, and an SL4J implementation, which is excluded by the Quarkus Amazon Alexa extension.