Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add and remove extension from single module project #10678

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Add and remove extension from single module project #10678

merged 1 commit into from
Jul 14, 2020

Conversation

Garima829
Copy link
Contributor

made test to add and remove extension in single module project

@boring-cyborg boring-cyborg bot added the area/gradle Gradle label Jul 13, 2020
@Garima829 Garima829 marked this pull request as ready for review July 13, 2020 13:47
gastaldi
gastaldi approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍

@gastaldi gastaldi added this to the 1.7.0 - master milestone Jul 13, 2020
@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 13, 2020
@gastaldi gastaldi merged commit 1c54cd8 into quarkusio:master Jul 14, 2020
@gastaldi
Copy link
Contributor

@Garima829 Thank you for your contribution!

@Garima829
Copy link
Contributor Author

My pleasure sir! :)

@Garima829 Garima829 deleted the ExtBranch branch July 14, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/gradle Gradle triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.7.0.CR1
Development

Successfully merging this pull request may close these issues.
2 participants
@Garima829 @gastaldi