funqy docs disclaimers and usage improvements #10693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastaldi
reviewed
Jul 13, 2020
gastaldi
approved these changes
Jul 13, 2020
|
It would be nice to squash these commits before merging |
|
Await on #10667 on whether to merge or not. |
patriot1burke
force-pushed
the
funqy-improvements
branch
from
9183a0d to
445473e
Compare
loicmathieu
requested changes
Jul 14, 2020
patriot1burke
force-pushed
the
funqy-improvements
branch
from
381a0a5 to
c18ea69
Compare
boring-cyborg
bot
added
area/core
area/devtools
patriot1burke
force-pushed
the
funqy-improvements
branch
from
c18ea69 to
3464759
Compare
Update docs/src/main/asciidoc/funqy.adoc Co-authored-by: George Gastaldi <[email protected]> Update docs/src/main/asciidoc/funqy.adoc Co-authored-by: Loïc Mathieu <[email protected]> Update docs/src/main/asciidoc/funqy.adoc Co-authored-by: Loïc Mathieu <[email protected]> add links
patriot1burke
force-pushed
the
funqy-improvements
branch
from
3464759 to
56fdf50
Compare
There was a problem hiding this comment.
LGTM; A good clarification which helps to set expectations right. Thanks, @stuartwdouglas and @patriot1burke. One suggestion inline.
|
|
||
| include::./status-include.adoc[] | ||
|
|
||
| Follow the link:amazon-lambda-http[Amazon Lambda Http Guide]. It walks through using a variety of HTTP | ||
| frameworks on Amazon Lambda, including Funqy. | ||
|
|
||
| WARNING: The Funqy HTTP + AWS Lambda binding is not a replacement for REST over HTTP. Because Funqy |
There was a problem hiding this comment.
Small suggestion; I'd put this into an admonition block (here and the other occurrences):
[NOTE]
====
The Funqy HTTP + AWS Lambda binding...
====
There was a problem hiding this comment.
Well, it is an admonition, it just uses the shortcut. I think it's good enough this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's been some confusion on when to use Funqy, especially with HTTP. Also, the docs were misleading users into thinking that the AwsContext interface could be injected in Lambda environments.