Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Improve the OIDC/OAuth2 documentation" #10700

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Revert "Improve the OIDC/OAuth2 documentation" #10700

merged 1 commit into from
Jul 13, 2020

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented Jul 13, 2020

This reverts commit dfdcad9.

I had to revert it because of #10653 (comment)

@gastaldi gastaldi merged commit 161cac3 into quarkusio:master Jul 13, 2020
@gastaldi gastaldi added this to the 1.7.0 - master milestone Jul 13, 2020
@sberyozkin
Copy link
Member

@gastaldi @geoand thanks, what is the correct sequence to fix it now, I think I deleted the local branch ?

@sberyozkin
Copy link
Member

sberyozkin commented Jul 13, 2020

May be we have reverted it too fast :-) ? I.e, we don't have 1.7.0 RC1 tomorrow, etc, I just merged it a few hours back, get back online, and it has been reverted...

@sberyozkin
Copy link
Member

Never mind, just ignore me, obviously it was causing the PR build failures, sorry for a mess

@sberyozkin
Copy link
Member

@gastaldi So what do I do now, create a branch, revert this revert PR and add another commit which fixes the issue ? It will probably be a messy commit sequence...I think it would be simpler just to create a new PR completely...

@gastaldi
Copy link
Contributor Author

@sberyozkin Yeah, I think the best is to create a new commit based on the reverted commit. You can use git revert --no-commit to not commit the reversion

@sberyozkin
Copy link
Member

@gastaldi @geoand sorry for being a bit edgy about the revert, I was so happy during my walk that I could continue with the next doc updates round tomorrow :-). But I think I'll create an issue, the PR was green as far as I recall... thanks

@sberyozkin
Copy link
Member

Yeah, docs is clean which is what I was checking, but documentation is broken

@gastaldi
Copy link
Contributor Author

There is something wrong with CI. The Documentation build shouldn't have passed

@geoand
Copy link
Contributor

geoand commented Jul 14, 2020

No worries @sberyozkin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants