-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Improve the OIDC/OAuth2 documentation" #10700
Conversation
This reverts commit dfdcad9.
May be we have reverted it too fast :-) ? I.e, we don't have 1.7.0 RC1 tomorrow, etc, I just merged it a few hours back, get back online, and it has been reverted... |
Never mind, just ignore me, obviously it was causing the PR build failures, sorry for a mess |
@gastaldi So what do I do now, create a branch, revert this revert PR and add another commit which fixes the issue ? It will probably be a messy commit sequence...I think it would be simpler just to create a new PR completely... |
@sberyozkin Yeah, I think the best is to create a new commit based on the reverted commit. You can use |
Yeah, |
There is something wrong with CI. The Documentation build shouldn't have passed |
No worries @sberyozkin! |
This reverts commit dfdcad9.
I had to revert it because of #10653 (comment)