Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document SyntheticBeanBuildItem #10721

Merged
merged 2 commits into from
Jul 15, 2020
Merged

Document SyntheticBeanBuildItem #10721

merged 2 commits into from
Jul 15, 2020

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jul 14, 2020

@mkouba mkouba requested a review from manovotn July 14, 2020 15:35
@mkouba mkouba added this to the 1.7.0 - master milestone Jul 14, 2020
gastaldi
gastaldi approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

geoand
geoand approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this (great) information should also be present in the extension author's guide (as this information is useful primarily - if not exclusively - for extension code)

@mkouba
Copy link
Contributor Author

mkouba commented Jul 15, 2020

@geoand Good idea. I'll try to update the "Expose your components via CDI" section...

@mkouba
Copy link
Contributor Author

mkouba commented Jul 15, 2020

@geoand @gastaldi updated...

geoand
geoand approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@mkouba mkouba mentioned this pull request Jul 15, 2020
Closed
2 tasks
manovotn
manovotn approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkouba mkouba merged commit bf47b2f into quarkusio:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

@manovotn manovotn manovotn approved these changes

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/documentation
Projects
None yet
Milestone
1.7.0.CR1
Development

Successfully merging this pull request may close these issues.

Document SyntheticBeanBuildItem
4 participants
@mkouba @gastaldi @manovotn @geoand