Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ResteasyServerCommonProcessor - fix resource method reflective scanning #10751

Merged
merged 1 commit into from
Jul 16, 2020
Merged

ResteasyServerCommonProcessor - fix resource method reflective scanning #10751

merged 1 commit into from
Jul 16, 2020

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jul 15, 2020

@mkouba
ResteasyServerCommonProcessor - fix resource method reflective scanning
6c68dba 
- do not register the ReflectiveHierarchyBuildItem twice for most
resource methods; first try the BeanArchiveIndexBuildItem and then add
methods only found in the CombinedIndexBuildItem
- resolves quarkusio#10742
@mkouba mkouba requested review from gsmet and gwenneg July 15, 2020 12:29
@mkouba
Copy link
Contributor Author

mkouba commented Jul 15, 2020

CC @pilhuhn

@mkouba mkouba added this to the 1.7.0 - master milestone Jul 15, 2020
@gsmet
Copy link
Member

gsmet commented Jul 15, 2020

I think JsonString should probably be added here: https://github.com/quarkusio/quarkus/blob/master/extensions/resteasy-common/deployment/src/main/java/io/quarkus/resteasy/common/deployment/ResteasyDotNames.java#L77 .

If you can do that in a separate PR, I would be able to backport it.

@mkouba
Copy link
Contributor Author

mkouba commented Jul 15, 2020

@gsmet hm, so this PR is valid but we don't need to register anything from javax.json for reflection because the API is used directly by a provider, right?

@gsmet
Copy link
Member

gsmet commented Jul 16, 2020

Yes. At least if the AnnotationInstance equals() and hashCode() is usable :).

@mkouba
Copy link
Contributor Author

mkouba commented Jul 16, 2020

I believe they are usable: https://github.com/wildfly/jandex/blob/master/src/main/java/org/jboss/jandex/AnnotationInstance.java#L324-L357

@mkouba mkouba mentioned this pull request Jul 16, 2020
Merged
@gsmet gsmet merged commit 3ff99ea into quarkusio:master Jul 16, 2020
@gsmet gsmet modified the milestones: 1.7.0 - master, 1.6.1.Final Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@gwenneg gwenneg Awaiting requested review from gwenneg

Assignees
No one assigned
Labels
area/core area/resteasy-classic
Projects
None yet
Milestone
1.6.1.Final
Development

Successfully merging this pull request may close these issues.

Jandex warning at boot time about JsonString
2 participants
@mkouba @gsmet