-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quartz - improve the error message when scheduler is disabled and org.quartz.Scheduler is injected #10754
Conversation
... and org.quartz.Scheduler is injected - resolve quarkusio#10633
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I just added a small comment about the doc. Could you check and dismiss the review one sorted out?
Thanks!
@@ -207,6 +207,8 @@ class MyJobs { | |||
} | |||
---- | |||
|
|||
NOTE: By default, the scheduler is not started unless a `@Scheduled` business method is found. You may need to force the start of the scheduler for "pure" programmatic scheduling. See also <<quartz.adoc#quartz-configuration-reference,Quartz Configuration Reference>>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely sure how this link will be rendered in the HTML. We need it to end up being quartz
without any extension.
Could you check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It renders just fine. Actually, it's the only way I found to link a section from a different document. See https://asciidoctor.org/docs/user-manual/#inter-document-cross-references.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My fear was that it renders with .html
at the end which would not help with SEO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah and that's exactly what happens unfortunately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I fixed the issue here: quarkusio/quarkusio.github.io#661 .
But if another pair of eyes can check that I didn't break something else, that would be welcome!
It's the only way I found to link a section from a different document
... and org.quartz.Scheduler is injected
The error message is:
java.lang.IllegalStateException: Quartz scheduler is either explicitly disabled through quarkus.scheduler.enabled=false or no @Scheduled methods were found. If you only need to schedule a job programmatically you can force the start of the scheduler via quarkus.quartz.force-start=true
.