Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quartz - improve the error message when scheduler is disabled and org.quartz.Scheduler is injected #10754

Merged
merged 1 commit into from
Jul 15, 2020

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jul 15, 2020

... and org.quartz.Scheduler is injected

The error message is: java.lang.IllegalStateException: Quartz scheduler is either explicitly disabled through quarkus.scheduler.enabled=false or no @Scheduled methods were found. If you only need to schedule a job programmatically you can force the start of the scheduler via quarkus.quartz.force-start=true.

... and org.quartz.Scheduler is injected
- resolve quarkusio#10633
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 15, 2020
@gsmet gsmet changed the title Quartz - improve the error message when scheduler is disabled... Quartz - improve the error message when scheduler is disabled and org.quartz.Scheduler is injected Jul 15, 2020
gsmet
gsmet previously requested changes Jul 15, 2020
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I just added a small comment about the doc. Could you check and dismiss the review one sorted out?

Thanks!

@@ -207,6 +207,8 @@ class MyJobs {
}
----

NOTE: By default, the scheduler is not started unless a `@Scheduled` business method is found. You may need to force the start of the scheduler for "pure" programmatic scheduling. See also <<quartz.adoc#quartz-configuration-reference,Quartz Configuration Reference>>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure how this link will be rendered in the HTML. We need it to end up being quartz without any extension.

Could you check?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It renders just fine. Actually, it's the only way I found to link a section from a different document. See https://asciidoctor.org/docs/user-manual/#inter-document-cross-references.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My fear was that it renders with .html at the end which would not help with SEO.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah and that's exactly what happens unfortunately.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I fixed the issue here: quarkusio/quarkusio.github.io#661 .

But if another pair of eyes can check that I didn't break something else, that would be welcome!

@mkouba mkouba dismissed gsmet’s stale review July 15, 2020 13:49

It's the only way I found to link a section from a different document

@gsmet gsmet merged commit f2d5968 into quarkusio:master Jul 15, 2020
@gsmet gsmet modified the milestones: 1.7.0 - master, 1.6.1.Final Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation area/scheduler triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a better exception message when Quartz is used
5 participants