Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creates maven profiles for integration tests #10763

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Creates maven profiles for integration tests #10763

merged 1 commit into from
Oct 22, 2020

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Jul 15, 2020

Allows running groups of test in CI builds with commands like:

mvn -e -pl integration-tests -amd -PIT-Security1 verify
mvn -e -pl integration-tests -amd -Dnative -PIT-Security1 verify
mvn -e -pl integration-tests -amd -Dno-format -DskipDocs -Dnative -PIT-Security1 verify

etc.

@boring-cyborg boring-cyborg bot added the area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure label Jul 15, 2020
@zakkak zakkak force-pushed the maven-it-profiles-for-ci branch 4 times, most recently from e0d87cf to 3364f88 Compare July 15, 2020 23:45
@geoand geoand requested review from n1hility and gsmet July 16, 2020 10:53
@gastaldi gastaldi added the triage/needs-rebase This PR needs to be rebased first because it has merge conflicts label Jul 23, 2020
galderz
galderz approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@galderz galderz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It appears the build run fine too.

Needs rebasing though and verify that the build continues to work well after that.

@zakkak zakkak mentioned this pull request Jul 27, 2020
Closed
@zakkak zakkak force-pushed the maven-it-profiles-for-ci branch 3 times, most recently from d2e2da0 to 911267d Compare July 28, 2020 18:10
@gastaldi gastaldi removed the triage/needs-rebase This PR needs to be rebased first because it has merge conflicts label Jul 29, 2020
@galderz
Copy link
Member

galderz commented Aug 7, 2020

Needs rebasing again :\

@zakkak
Copy link
Contributor Author

zakkak commented Aug 10, 2020

@gsmet @n1hility could you please give me some feedback on this before I invest time on a second rebase?

@zakkak
Copy link
Contributor Author

zakkak commented Sep 23, 2020 •
edited
Loading

@gsmet @n1hility this is a kind reminder.

Changes:

require updating the workflows of mandrel and graal (again) while with this PR we would have avoided this.

@zakkak
Copy link
Contributor Author

zakkak commented Oct 8, 2020

@gsmet @n1hility this is another kind reminder :)

@gastaldi
Copy link
Contributor

@zakkak it needs another rebase :)

@gastaldi
Copy link
Contributor

@zakkak I like this approach. My only concern is if once we start using GIB (https://github.com/vackosar/gitflow-incremental-builder) this won't become a burden? @famod any thoughts?

@gastaldi gastaldi added the triage/needs-rebase This PR needs to be rebased first because it has merge conflicts label Oct 13, 2020
@famod
Copy link
Member

famod commented Oct 13, 2020

@gastaldi

My only concern is if once we start using GIB (https://github.com/vackosar/gitflow-incremental-builder) this won't become a burden? @famod any thoughts?

Well, I haven't tested GIB with this setup, but theoretically there shouldn't be a problem.
I might be able to try it out later this week (Sunday at the latest).

@zakkak
Copy link
Contributor Author

zakkak commented Oct 14, 2020

@gastaldi I know it needs another rebase, but before investing time on it I would like to get some feedback (I guess you covered that part ) and hopefully a confirmation that this will get merged after the rebase so that it won't end up needing yet another rebase :)

Now waiting for @famod 's OK as well :)

@famod
Copy link
Member

famod commented Oct 18, 2020

I've tested this briefly with GIB and it works as expected!

@zakkak zakkak force-pushed the maven-it-profiles-for-ci branch from 911267d to 73867aa Compare October 22, 2020 04:45
@zakkak
Copy link
Contributor Author

zakkak commented Oct 22, 2020

Hi @gastaldi, this should now be up to date.

@zakkak zakkak force-pushed the maven-it-profiles-for-ci branch from 73867aa to d67bd11 Compare October 22, 2020 04:48
@zakkak
Creates maven profiles for integration tests
0569e82 
Allows running groups of test in CI builds with commands like:

    mvn -e -pl integration-tests -amd -PIT-Security1 verify
    mvn -e -pl integration-tests -amd -Dnative -PIT-Security1 verify
    mvn -e -pl integration-tests -amd -Dno-format -DskipDocs -Dnative -PIT-Security1 verify

etc.
@zakkak zakkak force-pushed the maven-it-profiles-for-ci branch from d67bd11 to 0569e82 Compare October 22, 2020 07:54
gastaldi
gastaldi approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Any objections that may impact the next release @gsmet ?

@gastaldi gastaldi merged commit 70be9e6 into quarkusio:master Oct 22, 2020
@gastaldi
Copy link
Contributor

Merged. Let's see how that goes. Thanks!

@zakkak
Copy link
Contributor Author

zakkak commented Oct 22, 2020

Thanks @gastaldi

@zakkak zakkak deleted the maven-it-profiles-for-ci branch October 22, 2020 20:11
@gsmet gsmet added this to the 1.10 - master milestone Oct 27, 2020
@gsmet
Copy link
Member

gsmet commented Oct 27, 2020

The doc at the bottom of https://github.com/quarkusio/quarkus/blob/master/CONTRIBUTING.md#frequently-asked-questions needs an update.

@zakkak
Copy link
Contributor Author

zakkak commented Oct 27, 2020

The doc at the bottom of https://github.com/quarkusio/quarkus/blob/master/CONTRIBUTING.md#frequently-asked-questions needs an update.

👍 Noted!

@zakkak zakkak restored the maven-it-profiles-for-ci branch October 27, 2020 17:25
@zakkak zakkak deleted the maven-it-profiles-for-ci branch October 27, 2020 17:25
@zakkak zakkak mentioned this pull request Oct 27, 2020
Merged
@zakkak zakkak mentioned this pull request Nov 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galderz galderz galderz approved these changes

@gastaldi gastaldi gastaldi approved these changes

@n1hility n1hility Awaiting requested review from n1hility

@gsmet gsmet Awaiting requested review from gsmet

Assignees
No one assigned
Labels
area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure triage/needs-rebase This PR needs to be rebased first because it has merge conflicts
Projects
None yet
Milestone
1.10.0.CR1
Development

Successfully merging this pull request may close these issues.
5 participants
@zakkak @galderz @gastaldi @famod @gsmet