Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Route annotations with the same values share a single handler instance #10782

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Route annotations with the same values share a single handler instance #10782

merged 1 commit into from
Jul 16, 2020

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jul 16, 2020

IMPL NOTE: We need a deterministic way to bind a generated handler to a @Route annotation. Therefore, we decided to group @Route annotations by their AnnotationInstance#toString(boolean) which includes all annotation values and since the values of AnnotationInstance are always sorted by name it's good enough for our purpose.

@mkouba mkouba requested a review from cescoffier July 16, 2020 14:47
@mkouba mkouba added this to the 1.7.0 - master milestone Jul 16, 2020
@cescoffier
Copy link
Member

LGTM!

@gastaldi gastaldi merged commit 2f415de into quarkusio:master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/reactive area/vertx
Projects
None yet
Milestone
1.7.0.CR1
Development

Successfully merging this pull request may close these issues.

Generate a RouteHandler per reactive route
3 participants
@mkouba @cescoffier @gastaldi