Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken trustStore usage in RestClient in native mode #10883

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Fix broken trustStore usage in RestClient in native mode #10883

merged 1 commit into from
Jul 21, 2020

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jul 21, 2020 •
edited
Loading

Before this change, when a user setup a trustStore
or keyStore for REST Client programmatically,
then in native mode that setting was being discarded
due to how ClientHttpEngineBuilder43 uses the
properties.

Fixes: #10877

@geoand
Fix broken trustStore usage in RestClient
4094fc3 
Before this change, when a user setup a trustStore
or keyStore for REST Client programmatically,
then in native mode that setting was being discarded
due to how ClientHttpEngineBuilder43 uses the
properties.

Fixes: quarkusio#10877
@geoand geoand mentioned this pull request Jul 21, 2020
Closed
@geoand geoand changed the title Fix broken trustStore usage in RestClient Fix broken trustStore usage in RestClient in native mode Jul 21, 2020
@geoand geoand requested a review from gsmet July 21, 2020 11:18
gastaldi
gastaldi approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gastaldi gastaldi modified the milestone: 1.7.0 - master Jul 21, 2020
@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 21, 2020
@geoand geoand merged commit cc50ba1 into quarkusio:master Jul 21, 2020
@geoand geoand deleted the #10877 branch July 21, 2020 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

@gsmet gsmet Awaiting requested review from gsmet

Assignees
No one assigned
Labels
area/rest-client triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.7.0.CR1
Development

Successfully merging this pull request may close these issues.

Rest-Client TrustStore Configuration no longer possible via properties in native (regression)
3 participants
@geoand @gastaldi @gsmet