Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev mode: don't include local projects of irrelevant versions #10914

Merged
merged 1 commit into from
Jul 22, 2020
Merged

Dev mode: don't include local projects of irrelevant versions #10914

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions devtools/maven/src/main/java/io/quarkus/maven/DevMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -925,6 +925,11 @@ private List<LocalProject> filterExtensionDependencies(LocalProject localProject
if (project == null) {
continue;
}
if (!project.getVersion().equals(a.getVersion())) {
getLog().warn(depKey + " is excluded from live coding since the application depends on version "
+ a.getVersion() + " while the version present in the workspace is " + project.getVersion());
continue;
}
if (project.getClassesDir() != null &&
//if this project also contains Quarkus extensions we do no want to include these in the discovery
//a bit of an edge case, but if you try and include a sample project with your extension you will
Expand Down