Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify in JavaDoc that logging does not work in test LifecycleManager #10920

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Clarify in JavaDoc that logging does not work in test LifecycleManager #10920

merged 1 commit into from
Jul 23, 2020

Conversation

famod
Copy link
Member

@famod famod commented Jul 22, 2020

Fixes #10885 (by just documenting the limitation)

@famod famod requested a review from geoand July 22, 2020 21:49
@gastaldi gastaldi merged commit ae4fa2f into quarkusio:master Jul 23, 2020
geoand
geoand reviewed Jul 23, 2020
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@gsmet gsmet added this to the 1.7.0 - master milestone Jul 28, 2020
@famod famod deleted the issue-10885-javadoc-logging-QTRLM branch August 27, 2020 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand left review comments

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/testing
Projects
None yet
Milestone
1.7.0.CR1
Development

Successfully merging this pull request may close these issues.

No logs on exception in QuarkusTestResourceLifecycleManager.start
4 participants
@famod @gastaldi @geoand @gsmet