-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial OpenAPI support for Vert.x #10944
Conversation
Signed-off-by: Phillip Kruger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I'm sorry for my ignorance but what's the scope of the initial OpenAPI support for Vert.x? I mean there are no OpenAPI annotations in the tests, no docs... |
Hi @mkouba - this is generating openapi from the new vertx |
Ok, thanks Phillip! So these are the important asserts 😄 How about the docs? Do you plan to send a follow-up PR and update the Reactive Routes guide? |
@mkouba - yes I can definitely update the docs as well. Happy to do it in this PR or a next. Might be easier in a next as this one is green already :) |
Here is the resources being test in SmallRye: Any OpenAPI annotations should also work, but we can definably add more tests for that. It's get's fully tested in the Jax-rs tests, and the Spring and Vert.x only test their annotations. |
This PR adds initial support for Vert.x
@Route
to be included in the OpenAPI schema generation.Fixes #10670
Fixes #8435
Signed-off-by: Phillip Kruger [email protected]