Added support to Quartz Plugins And Listeners

[marcelorubim]

Added support to Quartz Plugins And Listeners, as described on issue #10962

Fix #10962

[marcelorubim]

Well, there is no log at the failed pipe (Quarkus CI / JDK Java 14 JVM Tests (pull_request)). Should I send another commit to it to retry?

[mkouba]

Hi @marcelorubim, thanks for your contribution! Your PR should include at least some basic tests (you can follow the tests in https://github.com/quarkusio/quarkus/tree/master/extensions/quartz/deployment/src/test/java/io/quarkus/quartz/test). Furthermore, your branch should be squashed down to a single buildable commit. And finally, the issue is still being discussed so pls keep an eye on the comments...

[mkouba]

That's not a good plugin to test. We do shutdown the quartz scheduler when a quarkus app/test stops ;-).

[marcelorubim]

This test is because if I register an invalid plugin, the Quartz won't start. The test can check if parsing the config to Quartz properties is working fine.

[machi1990]

Thank you for the PR @marcelorubim I'd suggest we test we add an integration test too. Things like class registration for reflection would most likely be needed and having an integration test https://github.com/quarkusio/quarkus/tree/master/integration-tests/quartz would most likely show this up and avoid future regressions.

[marcelorubim]

Thank you for the PR @marcelorubim I'd suggest we test we add an integration test too. Things like class registration for reflection would most likely be needed and having an integration test https://github.com/quarkusio/quarkus/tree/master/integration-tests/quartz would most likely show this up and avoid future regressions.

Added this on application.properties on the integration test:

# Register de LoggingJobHistoryPlugin for testing
quarkus.quartz.plugin.jobHistory.class=org.quartz.plugins.history.LoggingJobHistoryPlugin
quarkus.quartz.plugin.jobHistory.jobSuccessMessage=Job [{1}.{0}] execution complete and reports: {8}

And this to QuartzProcessor.

        config.triggerListeners.values().forEach((value) -> {
            reflectiveClasses.add(new ReflectiveClassBuildItem(true, false, value.clazz));
        });

        config.jobListeners.values().forEach((value) -> {
            reflectiveClasses.add(new ReflectiveClassBuildItem(true, false, value.clazz));
        });

        config.plugins.values().forEach((value) -> {
            reflectiveClasses.add(new ReflectiveClassBuildItem(true, false, value.clazz));
        });

Now seems to works just fine on native mode.

[machi1990]

@marcelorubim thank you for the wonderful work. It is looking great, I like your configuration proposal much better than the plain Map<String, Map<String, String>>.

I've added comments, and once they are addressed this is good to merge.

[machi1990]

Thank you @marcelorubim. All good for me.

@mkouba do you want to have a look?

[mkouba]

Looks really good. I've added few minor docs comments.

[gsmet]

Minor gripe: any chance you could adjust the commit message? git commit --amend should allow you to do that and then force push.

Thanks!

[gsmet]

Thanks! Let's wait for CI and merge.

[gsmet]

Merged, thanks!

[machi1990]

Thank you @marcelorubim for the PR.