Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Funqy HTTP query parameter binding #10968

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Funqy HTTP query parameter binding #10968

merged 1 commit into from
Jul 30, 2020

Conversation

patriot1burke
Copy link
Contributor

For GET requests, query parameters can now be mapped to the input parameter. Previously, GET requests could not send input to functions.

@gunnarmorling

loicmathieu
loicmathieu previously requested changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@loicmathieu loicmathieu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I added a question about OffsetDateTime I also think more documentation of date support (which format for example) needs to be written.

@gsmet
Copy link
Member

gsmet commented Jul 29, 2020

@patriot1burke could you have a look at the review? I'm releasing CR1 tomorrow. Thanks!

gunnarmorling
gunnarmorling reviewed Jul 29, 2020
View reviewed changes
Copy link
Contributor

@gunnarmorling gunnarmorling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't look closely at the impl, but from the description in the guide it looks very useful 👍

@patriot1burke
Funqy HTTP query parameter support
bfdddac 
funqy query param list, set, map

query param doc

funqy yaml

Update docs/src/main/asciidoc/funqy-http.adoc

Co-authored-by: Loïc Mathieu <[email protected]>

offset datetime
@patriot1burke
Copy link
Contributor Author

@gsmet Resovled all comments. Should be good.

gsmet
gsmet approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loïc looked OK with it apart from the comments so merging.

@gsmet gsmet dismissed loicmathieu’s stale review July 30, 2020 08:16

Comments addressed.

@gsmet gsmet merged commit 574431b into quarkusio:master Jul 30, 2020
@gsmet gsmet added this to the 1.7.0 - master milestone Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gunnarmorling gunnarmorling gunnarmorling left review comments

@gsmet gsmet gsmet approved these changes

@loicmathieu loicmathieu loicmathieu left review comments

Assignees
No one assigned
Labels
area/documentation area/funqy kind/new-feature
Projects
None yet
Milestone
1.7.0.CR1
Development

Successfully merging this pull request may close these issues.
4 participants
@patriot1burke @gsmet @gunnarmorling @loicmathieu