Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for cache-from in Docker extension #10978

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Add support for cache-from in Docker extension #10978

merged 1 commit into from
Jul 27, 2020

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jul 27, 2020

Fixes: #10966

@geoand geoand mentioned this pull request Jul 27, 2020
Closed
@geoand geoand requested a review from gastaldi July 27, 2020 09:24
@geoand geoand added this to the 1.7.0 - master milestone Jul 27, 2020
gsmet
gsmet approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I'll let @gastaldi have the final say as you requested his review.

@geoand
Copy link
Contributor Author

geoand commented Jul 27, 2020 •
edited
Loading

Well it's a small change, so anyone with some familiarity with docker should be qualified to review it :)

gastaldi
gastaldi approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoand geoand merged commit 58d52ae into quarkusio:master Jul 27, 2020
@geoand geoand deleted the #10966 branch July 27, 2020 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.0.CR1
Development

Successfully merging this pull request may close these issues.

[container-image-docker] Add additional params to docker build command
3 participants
@geoand @gastaldi @gsmet