Fix explicit composite cache key elements values and improve doc #11046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoand
reviewed
Jul 29, 2020
docs/src/main/asciidoc/cache.adoc
Outdated
| @@ -327,6 +327,49 @@ method annotated with `@CacheResult` or `@CacheInvalidate`. | |||
|
|
|||
| This annotation is optional and should only be used when some of the method arguments are NOT part of the cache key. | |||
|
|
|||
| === Composite cache key building logic | |||
|
|
|||
| When a cache key is built from several method arguments, whether they are explicitly identified with `@CacheKey` or not, the building logic depends on these arguments order in the method signature. On the other hand, the arguments names are not used at all and do not have any effect on the cache key. | |||
There was a problem hiding this comment.
Suggested change
| When a cache key is built from several method arguments, whether they are explicitly identified with `@CacheKey` or not, the building logic depends on these arguments order in the method signature. On the other hand, the arguments names are not used at all and do not have any effect on the cache key. | |
| When a cache key is built from several method arguments, whether they are explicitly identified with `@CacheKey` or not, the building logic depends on the order of these arguments in the method signature. On the other hand, the arguments names are not used at all and do not have any effect on the cache key. |
geoand
approved these changes
Jul 29, 2020
gwenneg
force-pushed
the
issue-10436-cache-key-parameters-positions
branch
from
304c08a to
133263b
Compare
|
Suggestion applied, thanks for the review @geoand! |
gsmet
added
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10436.
cc @gsmet @geoand