Retire includeAllTimeZones for native executables entirely #11065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoand
approved these changes
Jul 29, 2020
| * Keeping it around for now as it marks the extension requiring all the timezones | ||
| * and better wait for the situation to fully settle on the GraalVM side | ||
| * before removing it entirely. | ||
| */ | ||
| public final class NativeImageEnableAllTimeZonesBuildItem extends MultiBuildItem { |
There was a problem hiding this comment.
Maybe mark it with @Deprecated?
There was a problem hiding this comment.
So I thought about that and decided not to for now. Otherwise people would remove the marker and I think keeping it for a few versions to be sure they don't retropedal is a good thing.
There was a problem hiding this comment.
OK, in the end I made it deprecated.
machi1990
requested changes
Jul 29, 2020
It's deprecated by GraalVM: all timezones are now included.
gsmet
force-pushed
the
retire-alltimezone-entirely
branch
from
1b6017b to
7666f6c
Compare
|
@machi1990 done except for the MySQL one. Let's still produce them for now as some sort of documentation. We can drop them later on when we remove the class. |
machi1990
approved these changes
Jul 29, 2020
|
This looks fine to me, @gsmet. On a slightly related note (one which shouldn't change the decision in this PR) is this current issue in GraalVM oracle/graal#2692 which currently affects some of the Quarkus applications. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's deprecated by GraalVM: all timezones are now included.
@jaikiran @Galder does it make sense?
Fix #11054