Wire up Server Push #11082
Merged
Wire up Server Push #11082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
approved these changes
Jul 30, 2020
gsmet
reviewed
Jul 30, 2020
| @@ -378,6 +379,7 @@ public void handle(RoutingContext event) { | |||
| event.remove(QuarkusHttpUser.AUTH_FAILURE_HANDLER); | |||
| VertxHttpExchange exchange = new VertxHttpExchange(event.request(), allocator, executorService, event, | |||
| event.getBody()); | |||
| exchange.setPushHandler(VertxHttpRecorder.getRootHandler()); | |||
There was a problem hiding this comment.
Just to be sure: at this point we are entirely sure that the root handler is set in VertxHttpRecorder?
There was a problem hiding this comment.
Yes. At this point the server is processing requests, if the root handler was not set then no request processing would be happening.
|
I force pushed to fix the import order. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.