Improve robustness of our devtools Gradle code #11517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area/devtools
|
@ia3andy @aloubyansky This is only small improvement for handling duplicate/platform dependencies. I didn't change any template code since it will be deprecated anyway. |
ia3andy
reviewed
Aug 21, 2020
...ools-common/src/main/java/io/quarkus/devtools/project/buildfile/AbstractGradleBuildFile.java
Show resolved
Hide resolved
|
@mgorniew just had a quick look, this looks great!! I will review it on monday :) |
aloubyansky
reviewed
Aug 21, 2020
devtools/gradle/src/main/java/io/quarkus/gradle/builder/QuarkusModelBuilder.java
Show resolved
Hide resolved
ia3andy
reviewed
Aug 25, 2020
devtools/gradle/src/main/java/io/quarkus/gradle/ConnectorDependencyResolver.java
Outdated
Show resolved
Hide resolved
mgorniew
force-pushed
the
iss_11303
branch
3 times, most recently
from
413759f to
57ead05
Compare
gastaldi
reviewed
Aug 25, 2020
...ation-tests/devtools/src/test/java/io/quarkus/devtools/commands/AddGradleExtensionsTest.java
Show resolved
Hide resolved
ia3andy
requested changes
Sep 11, 2020
...ools-common/src/main/java/io/quarkus/devtools/project/buildfile/AbstractGradleBuildFile.java
Outdated
Show resolved
Hide resolved
|
@mgorniew this PR is still draft, is it ready? |
|
cc @gsmet @sebersole |
|
@mgorniew are you still on that one? |
|
Yes, sorry. I will look into it today.
wt., 15 wrz 2020, 08:26 użytkownik Andy Damevin <[email protected]>
napisał:
… @mgorniew <https://github.com/mgorniew> are you still on that one?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11517 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADIDQ44QZARO3PTLRR5QACLSF4CI7ANCNFSM4QHEFWXQ>
.
|
|
@mgorniew if not a draft anymore can you switch it "ready for review"? |
mgorniew
force-pushed
the
iss_11303
branch
2 times, most recently
from
cddc27c to
7f38fac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to improve dependencies handling for Gradle. This leverages QuarkusModel from Gradle plugin to extract list of dependencies for project.
Fixes: #11303