Copy over the json files required by native-image tool during native-image generation on Windows #11649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring native-image generation on Windows
This was referenced Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11131
Fixes #11184
On Windows, there's currently a hack[1] where we build a uberjar when generating a native-image. This hack is to temporarily get around an unresolved issue in Graal VM. One thing that workaround misses is copying over the json configuration files that are sometimes present in an application to configure native image generation.
The commit here introduces that code to copy over these json files (like we do when generating a thin jar). I don't have a way to reproduce this or test this fix, but I think the change I made in the test should catch this in future.
[1] #8850