Platform JSON: support reading BOM's managed deps from a generated POM #11650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
area/devtools
aloubyansky
force-pushed
the
generate-json-from-pom
branch
3 times, most recently
from
673c4f0 to
70e8ec1
Compare
gsmet
force-pushed
the
generate-json-from-pom
branch
from
70e8ec1 to
6c48842
Compare
|
Force pushed a rebase. |
|
CI failure is unrelated. @quarkusio/devtools could one of you have a look? I have no idea what this PR does. |
|
@gsmet this change enables generating the BOM for the platform and use it for running the testsuite. Without it, the original BOM would be used in place of the generated one. |
|
@aloubyansky I'm not entirely sure this is needed for 1.8? I think we will need time to test and validate the platform changes and I'm not sure it's something we can do in time for 1.8. WDYT? |
|
I would like to have it in a released Quarkus version for my platform tests. The SNAPSHOT versions are not always passing the platform testsuite due to some incompatibilities. |
gsmet
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change supports picking up the content of the POM generated on the fly for the current project that has replaced the original project's POM.