Add some logging to codestarts #11803

ia3andy · 2020-09-02T07:17:08Z

Remove codestarts shared-data overrides from example codestarts
Add logs to codestarts

There are a lot of modified files because of package renaming, the PR in itself is not that big.

ia3andy · 2020-09-02T07:19:36Z

INFO:

-----------
selected extensions: 
- io.quarkus:quarkus-qute
- io.quarkus:quarkus-scala
- io.quarkus:quarkus-resteasy

🔥 qute-example codestart not applied (doesn't implement language 'scala' yet)

applying codestarts...
🔠 scala
🧰 maven
🗃 quarkus
📜 config-properties
🛠 dockerfiles
🛠 maven-wrapper
🐒 resteasy-example

-----------
👍 quarkus project has been successfully generated in:
--> /Users/ia3andy/workspace/redhat/quarkus/quarkus/target/kotlin-with-rest-is-qute-16
-----------

DEBUG:

-----------
DEBUG: Processed shared-data: {test-dependencies=[io.rest-assured:rest-assured], artifact-id=project-maven-java-resteasy-example-customized, java={version=1.8}, codestart-project={codestarts=[dockerfiles, maven-wrapper, resteasy-example], project={name=quarkus}, language={name=java}, buildtool={name=maven}, config={name=config-properties}}, quarkus={maven-plugin={artifact-id=quarkus-maven-plugin, group-id=io.quarkus, version=999-SNAPSHOT}, gradle-plugin={id=io.quarkus, version=999-SNAPSHOT}, version=999-SNAPSHOT, platform={artifact-id=quarkus-bom, group-id=io.quarkus, version=999-SNAPSHOT}}, resteasy-example={resource={path=/andy, class-name=AndyEndpoint}, package-name=com.test.andy}, supports={dev-mode=true, native=true}, project={group-id=org.test, artifact-id=test-codestart, version=1.0.0-codestart}, language={dir={code=src/main/java}}, buildtool={build-dir=target, guide=https://quarkus.io/guides/maven-tooling.html, guide-native=https://quarkus.io/guides/building-native-image, cmd={dev=./mvnw compile quarkus:dev, package=./mvnw package, package-uberjar=./mvnw package -PuberJar, package-native=./mvnw package -Pnative, package-native-container=./mvnw package -Pnative -Dquarkus.native.container-build=true}}, config={file-name=application.properties}, dependencies=[io.quarkus:quarkus-resteasy]}
DEBUG: File strategies: [mvnw->executable, .gitignore->append, README.adoc->forbidden, readme.md->forbidden, mvnw.cmd->executable, *->fail-on-duplicate, src/test/resources/application.properties->forbidden, pom.xml->smart-pom-merge, README.md->append, src/main/resources/application.properties->forbidden, src/test/resources/application.yml->smart-config-merge, readme.adoc->forbidden, src/native-test/*->native-test-dir-resolve, src/main/resources/application.yml->smart-config-merge]
DEBUG: Processing codestart 'java'...
DEBUG: codestart data: {test-dependencies=[io.rest-assured:rest-assured], gen-info={time=1599031152802}, codestart-project={codestarts=[dockerfiles, maven-wrapper, resteasy-example], project={name=quarkus}, language={name=java}, buildtool={name=maven}, config={name=config-properties}}, quarkus={maven-plugin={artifact-id=quarkus-maven-plugin, group-id=io.quarkus, version=999-SNAPSHOT}, gradle-plugin={id=io.quarkus, version=999-SNAPSHOT}, version=999-SNAPSHOT, platform={artifact-id=quarkus-bom, group-id=io.quarkus, version=999-SNAPSHOT}}, resteasy-example={resource={path=/andy, class-name=AndyEndpoint}, package-name=com.test.andy}, project={group-id=org.test, artifact-id=test-codestart, version=1.0.0-codestart}, language={dir={code=src/main/java}}, buildtool={build-dir=target, guide=https://quarkus.io/guides/maven-tooling.html, guide-native=https://quarkus.io/guides/building-native-image, cmd={dev=./mvnw compile quarkus:dev, package=./mvnw package, package-uberjar=./mvnw package -PuberJar, package-native=./mvnw package -Pnative, package-native-container=./mvnw package -Pnative -Dquarkus.native.container-build=true}}, version=1.8, dependencies=[io.quarkus:quarkus-resteasy], artifact-id=project-maven-java-resteasy-example-customized, java={version=1.8}, supports={dev-mode=true, native=true}, config={file-name=application.properties}}
DEBUG: Processing codestart 'quarkus'...
DEBUG: codestart data: {test-dependencies=[io.rest-assured:rest-assured], gen-info={time=1599031152806}, codestart-project={codestarts=[dockerfiles, maven-wrapper, resteasy-example], project={name=quarkus}, language={name=java}, buildtool={name=maven}, config={name=config-properties}}, quarkus={maven-plugin={artifact-id=quarkus-maven-plugin, group-id=io.quarkus, version=999-SNAPSHOT}, gradle-plugin={id=io.quarkus, version=999-SNAPSHOT}, version=999-SNAPSHOT, platform={artifact-id=quarkus-bom, group-id=io.quarkus, version=999-SNAPSHOT}}, resteasy-example={resource={path=/andy, class-name=AndyEndpoint}, package-name=com.test.andy}, project={group-id=org.test, artifact-id=test-codestart, version=1.0.0-codestart}, language={dir={code=src/main/java}}, buildtool={build-dir=target, guide=https://quarkus.io/guides/maven-tooling.html, guide-native=https://quarkus.io/guides/building-native-image, cmd={dev=./mvnw compile quarkus:dev, package=./mvnw package, package-uberjar=./mvnw package -PuberJar, package-native=./mvnw package -Pnative, package-native-container=./mvnw package -Pnative -Dquarkus.native.container-build=true}}, version=999-SNAPSHOT, platform={artifact-id=quarkus-bom, group-id=io.quarkus, version=999-SNAPSHOT}, dependencies=[io.quarkus:quarkus-resteasy], artifact-id=project-maven-java-resteasy-example-customized, java={version=1.8}, maven-plugin={artifact-id=quarkus-maven-plugin, group-id=io.quarkus, version=999-SNAPSHOT}, supports={dev-mode=true, native=true}, gradle-plugin={id=io.quarkus, version=999-SNAPSHOT}, config={file-name=application.properties}}
DEBUG: processing dir: /Users/ia3andy/workspace/redhat/quarkus/quarkus/devtools/platform-descriptor-json/target/classes/bundled-codestarts/project/quarkus/base
DEBUG: found source file: README.tpl.qute.md
DEBUG: using reader: io.quarkus.devtools.codestarts.reader.QuteCodestartFileReader
DEBUG: adding file to processing stack: /Users/ia3andy/workspace/redhat/quarkus/quarkus/devtools/platform-descriptor-json/target/classes/bundled-codestarts/project/quarkus/base/README.tpl.qute.md
DEBUG: found source file: ..gitignore
DEBUG: using reader: io.quarkus.devtools.codestarts.reader.CodestartFileReader$DefaultCodestartFileReader
DEBUG: adding file to processing stack: /Users/ia3andy/workspace/redhat/quarkus/quarkus/devtools/platform-descriptor-json/target/classes/bundled-codestarts/project/quarkus/base/..gitignore
DEBUG: found source file: src/main/resources/application.yml
DEBUG: using reader: io.quarkus.devtools.codestarts.reader.CodestartFileReader$DefaultCodestartFileReader
DEBUG: adding file to processing stack: /Users/ia3andy/workspace/redhat/quarkus/quarkus/devtools/platform-descriptor-json/target/classes/bundled-codestarts/project/quarkus/base/src/main/resources/application.yml
DEBUG: Processing codestart 'maven'...
DEBUG: codestart data: {test-dependencies=[io.rest-assured:rest-assured], gen-info={time=1599031153003}, maven-surefire-plugin={version=2.22.1}, codestart-project={codestarts=[dockerfiles, maven-wrapper, resteasy-example], project={name=quarkus}, language={name=java}, buildtool={name=maven}, config={name=config-properties}}, scala={version=2.12.8}, quarkus={maven-plugin={artifact-id=quarkus-maven-plugin, group-id=io.quarkus, version=999-SNAPSHOT}, gradle-plugin={id=io.quarkus, version=999-SNAPSHOT}, version=999-SNAPSHOT, platform={artifact-id=quarkus-bom, group-id=io.quarkus, version=999-SNAPSHOT}}, resteasy-example={resource={path=/andy, class-name=AndyEndpoint}, package-name=com.test.andy}, kotlin={version=1.3.72}, project={group-id=org.test, artifact-id=test-codestart, version=1.0.0-codestart}, language={dir={code=src/main/java}}, buildtool={build-dir=target, guide=https://quarkus.io/guides/maven-tooling.html, guide-native=https://quarkus.io/guides/building-native-image, cmd={dev=./mvnw compile quarkus:dev, package=./mvnw package, package-uberjar=./mvnw package -PuberJar, package-native=./mvnw package -Pnative, package-native-container=./mvnw package -Pnative -Dquarkus.native.container-build=true}}, dependencies=[io.quarkus:quarkus-resteasy], artifact-id=project-maven-java-resteasy-example-customized, java={version=1.8}, supports={dev-mode=true, native=true}, scala-maven-plugin={version=4.1.1}, config={file-name=application.properties}, maven-compiler-plugin={version=3.8.1}}
DEBUG: processing dir: /Users/ia3andy/workspace/redhat/quarkus/quarkus/devtools/platform-descriptor-json/target/classes/bundled-codestarts/buildtool/maven/base
DEBUG: found source file: ..gitignore
DEBUG: using reader: io.quarkus.devtools.codestarts.reader.CodestartFileReader$DefaultCodestartFileReader
DEBUG: adding file to processing stack: /Users/ia3andy/workspace/redhat/quarkus/quarkus/devtools/platform-descriptor-json/target/classes/bundled-codestarts/buildtool/maven/base/..gitignore
DEBUG: found source file: pom.tpl.qute.xml
DEBUG: using reader: io.quarkus.devtools.codestarts.reader.QuteCodestartFileReader
DEBUG: adding file to processing stack: /Users/ia3andy/workspace/redhat/quarkus/quarkus/devtools/platform-descriptor-json/target/classes/bundled-codestarts/buildtool/maven/base/pom.tpl.qute.xml
DEBUG: processing dir: /Users/ia3andy/workspace/redhat/quarkus/quarkus/devtools/platform-descriptor-json/target/classes/bundled-codestarts/buildtool/maven/java
DEBUG: found source file: .gitkeep
DEBUG: using reader: io.quarkus.devtools.codestarts.reader.IgnoreCodestartFileReader
DEBUG: ignoring file: /Users/ia3andy/workspace/redhat/quarkus/quarkus/devtools/platform-descriptor-json/target/classes/bundled-codestarts/buildtool/maven/java/.gitkeep
DEBUG: Processing codestart 'config-properties'...
DEBUG: codestart data: {test-dependencies=[io.rest-assured:rest-assured], gen-info={time=1599031153039}, codestart-project={codestarts=[dockerfiles, maven-wrapper, resteasy-example], project={name=quarkus}, language={name=java}, buildtool={name=maven}, config={name=config-properties}}, quarkus={maven-plugin={artifact-id=quarkus-maven-plugin, group-id=io.quarkus, version=999-SNAPSHOT}, gradle-plugin={id=io.quarkus, version=999-SNAPSHOT}, version=999-SNAPSHOT, platform={artifact-id=quarkus-bom, group-id=io.quarkus, version=999-SNAPSHOT}}, resteasy-example={resource={path=/andy, class-name=AndyEndpoint}, package-name=com.test.andy}, project={group-id=org.test, artifact-id=test-codestart, version=1.0.0-codestart}, language={dir={code=src/main/java}}, buildtool={build-dir=target, guide=https://quarkus.io/guides/maven-tooling.html, guide-native=https://quarkus.io/guides/building-native-image, cmd={dev=./mvnw compile quarkus:dev, package=./mvnw package, package-uberjar=./mvnw package -PuberJar, package-native=./mvnw package -Pnative, package-native-container=./mvnw package -Pnative -Dquarkus.native.container-build=true}}, dependencies=[io.quarkus:quarkus-resteasy], artifact-id=project-maven-java-resteasy-example-customized, java={version=1.8}, supports={dev-mode=true, native=true}, config={file-name=application.properties}}
DEBUG: Processing codestart 'dockerfiles'...
DEBUG: codestart data: {test-dependencies=[io.rest-assured:rest-assured], gen-info={time=1599031153040}, codestart-project={codestarts=[dockerfiles, maven-wrapper, resteasy-example], project={name=quarkus}, language={name=java}, buildtool={name=maven}, config={name=config-properties}}, quarkus={maven-plugin={artifact-id=quarkus-maven-plugin, group-id=io.quarkus, version=999-SNAPSHOT}, gradle-plugin={id=io.quarkus, version=999-SNAPSHOT}, version=999-SNAPSHOT, platform={artifact-id=quarkus-bom, group-id=io.quarkus, version=999-SNAPSHOT}}, resteasy-example={resource={path=/andy, class-name=AndyEndpoint}, package-name=com.test.andy}, dockerfile={jvm={from=registry.access.redhat.com/ubi8/ubi-minimal:8.1, java-package=java-11-openjdk-headless, run-java-version=1.3.8}, fast-jar={from=registry.access.redhat.com/ubi8/ubi-minimal:8.1, java-package=java-11-openjdk-headless, run-java-version=1.3.8}, native={from=registry.access.redhat.com/ubi8/ubi-minimal:8.1}}, project={group-id=org.test, artifact-id=test-codestart, version=1.0.0-codestart}, language={dir={code=src/main/java}}, buildtool={build-dir=target, guide=https://quarkus.io/guides/maven-tooling.html, guide-native=https://quarkus.io/guides/building-native-image, cmd={dev=./mvnw compile quarkus:dev, package=./mvnw package, package-uberjar=./mvnw package -PuberJar, package-native=./mvnw package -Pnative, package-native-container=./mvnw package -Pnative -Dquarkus.native.container-build=true}}, dependencies=[io.quarkus:quarkus-resteasy], artifact-id=project-maven-java-resteasy-example-customized, java={version=1.8}, supports={dev-mode=true, native=true}, config={file-name=application.properties}}
DEBUG: processing dir: /Users/ia3andy/workspace/redhat/quarkus/quarkus/devtools/platform-descriptor-json/target/classes/bundled-codestarts/tooling/dockerfiles/base
DEBUG: found source file: .dockerignore.tpl.qute
DEBUG: using reader: io.quarkus.devtools.codestarts.reader.QuteCodestartFileReader
DEBUG: adding file to processing stack: /Users/ia3andy/workspace/redhat/quarkus/quarkus/devtools/platform-descriptor-json/target/classes/bundled-codestarts/tooling/dockerfiles/base/.dockerignore.tpl.qute
DEBUG: found source file: src/main/docker/Dockerfile.tpl.qute.fast-jar
DEBUG: using reader: io.quarkus.devtools.codestarts.reader.QuteCodestartFileReader
DEBUG: adding file to processing stack: /Users/ia3andy/workspace/redhat/quarkus/quarkus/devtools/platform-descriptor-json/target/classes/bundled-codestarts/tooling/dockerfiles/base/src/main/docker/Dockerfile.tpl.qute.fast-jar
DEBUG: found source file: src/main/docker/Dockerfile.tpl.qute.jvm
DEBUG: using reader: io.quarkus.devtools.codestarts.reader.QuteCodestartFileReader
DEBUG: adding file to processing stack: /Users/ia3andy/workspace/redhat/quarkus/quarkus/devtools/platform-descriptor-json/target/classes/bundled-codestarts/tooling/dockerfiles/base/src/main/docker/Dockerfile.tpl.qute.jvm
DEBUG: found source file: src/main/docker/Dockerfile.tpl.qute.native
DEBUG: using reader: io.quarkus.devtools.codestarts.reader.QuteCodestartFileReader
DEBUG: adding file to processing stack: /Users/ia3andy/workspace/redhat/quarkus/quarkus/devtools/platform-descriptor-json/target/classes/bundled-codestarts/tooling/dockerfiles/base/src/main/docker/Dockerfile.tpl.qute.native
DEBUG: Processing codestart 'maven-wrapper'...
DEBUG: codestart data: {test-dependencies=[io.rest-assured:rest-assured], gen-info={time=1599031153053}, codestart-project={codestarts=[dockerfiles, maven-wrapper, resteasy-example], project={name=quarkus}, language={name=java}, buildtool={name=maven}, config={name=config-properties}}, maven={version=0.5.6}, quarkus={maven-plugin={artifact-id=quarkus-maven-plugin, group-id=io.quarkus, version=999-SNAPSHOT}, gradle-plugin={id=io.quarkus, version=999-SNAPSHOT}, version=999-SNAPSHOT, platform={artifact-id=quarkus-bom, group-id=io.quarkus, version=999-SNAPSHOT}}, resteasy-example={resource={path=/andy, class-name=AndyEndpoint}, package-name=com.test.andy}, project={group-id=org.test, artifact-id=test-codestart, version=1.0.0-codestart}, language={dir={code=src/main/java}}, buildtool={build-dir=target, guide=https://quarkus.io/guides/maven-tooling.html, guide-native=https://quarkus.io/guides/building-native-image, cmd={dev=./mvnw compile quarkus:dev, package=./mvnw package, package-uberjar=./mvnw package -PuberJar, package-native=./mvnw package -Pnative, package-native-container=./mvnw package -Pnative -Dquarkus.native.container-build=true}}, dependencies=[io.quarkus:quarkus-resteasy], artifact-id=project-maven-java-resteasy-example-customized, java={version=1.8}, supports={dev-mode=true, native=true}, config={file-name=application.properties}}
DEBUG: processing dir: /Users/ia3andy/workspace/redhat/quarkus/quarkus/devtools/platform-descriptor-json/target/classes/bundled-codestarts/tooling/maven-wrapper/base
DEBUG: found source file: mvnw.tpl.qute.cmd
DEBUG: using reader: io.quarkus.devtools.codestarts.reader.QuteCodestartFileReader
DEBUG: adding file to processing stack: /Users/ia3andy/workspace/redhat/quarkus/quarkus/devtools/platform-descriptor-json/target/classes/bundled-codestarts/tooling/maven-wrapper/base/mvnw.tpl.qute.cmd
DEBUG: found source file: mvnw.tpl.qute
DEBUG: using reader: io.quarkus.devtools.codestarts.reader.QuteCodestartFileReader
DEBUG: adding file to processing stack: /Users/ia3andy/workspace/redhat/quarkus/quarkus/devtools/platform-descriptor-json/target/classes/bundled-codestarts/tooling/maven-wrapper/base/mvnw.tpl.qute
DEBUG: Processing codestart 'resteasy-example'...
DEBUG: codestart data: {test-dependencies=[io.rest-assured:rest-assured], gen-info={time=1599031153062}, codestart-project={codestarts=[dockerfiles, maven-wrapper, resteasy-example], project={name=quarkus}, language={name=java}, buildtool={name=maven}, config={name=config-properties}}, resource={class-name=AndyEndpoint, path=/andy, response=hello}, quarkus={maven-plugin={artifact-id=quarkus-maven-plugin, group-id=io.quarkus, version=999-SNAPSHOT}, gradle-plugin={id=io.quarkus, version=999-SNAPSHOT}, version=999-SNAPSHOT, platform={artifact-id=quarkus-bom, group-id=io.quarkus, version=999-SNAPSHOT}}, resteasy-example={resource={path=/andy, class-name=AndyEndpoint}, package-name=com.test.andy}, project={group-id=org.test, artifact-id=test-codestart, version=1.0.0-codestart}, language={dir={code=src/main/java}}, buildtool={build-dir=target, guide=https://quarkus.io/guides/maven-tooling.html, guide-native=https://quarkus.io/guides/building-native-image, cmd={dev=./mvnw compile quarkus:dev, package=./mvnw package, package-uberjar=./mvnw package -PuberJar, package-native=./mvnw package -Pnative, package-native-container=./mvnw package -Pnative -Dquarkus.native.container-build=true}}, package-name=com.test.andy, dependencies=[io.quarkus:quarkus-resteasy], artifact-id=project-maven-java-resteasy-example-customized, java={version=1.8}, supports={dev-mode=true, native=true}, config={file-name=application.properties}}
DEBUG: processing dir: /Users/ia3andy/workspace/redhat/quarkus/quarkus/devtools/platform-descriptor-json/target/classes/bundled-codestarts/code/resteasy-example/base
DEBUG: found source file: README.md
DEBUG: using reader: io.quarkus.devtools.codestarts.reader.CodestartFileReader$DefaultCodestartFileReader
DEBUG: adding file to processing stack: /Users/ia3andy/workspace/redhat/quarkus/quarkus/devtools/platform-descriptor-json/target/classes/bundled-codestarts/code/resteasy-example/base/README.md
DEBUG: found source file: src/main/resources/META-INF/resources/index.tpl.qute.html
DEBUG: using reader: io.quarkus.devtools.codestarts.reader.QuteCodestartFileReader
DEBUG: adding file to processing stack: /Users/ia3andy/workspace/redhat/quarkus/quarkus/devtools/platform-descriptor-json/target/classes/bundled-codestarts/code/resteasy-example/base/src/main/resources/META-INF/resources/index.tpl.qute.html
DEBUG: processing dir: /Users/ia3andy/workspace/redhat/quarkus/quarkus/devtools/platform-descriptor-json/target/classes/bundled-codestarts/code/resteasy-example/java
DEBUG: found source file: src/test/java/{package-name.dir}/{resource.class-name}Test.tpl.qute.java
DEBUG: using reader: io.quarkus.devtools.codestarts.reader.QuteCodestartFileReader
DEBUG: adding file to processing stack: /Users/ia3andy/workspace/redhat/quarkus/quarkus/devtools/platform-descriptor-json/target/classes/bundled-codestarts/code/resteasy-example/java/src/test/java/{package-name.dir}/{resource.class-name}Test.tpl.qute.java
DEBUG: found source file: src/native-test/java/{package-name.dir}/Native{resource.class-name}IT.tpl.qute.java
DEBUG: using reader: io.quarkus.devtools.codestarts.reader.QuteCodestartFileReader
DEBUG: adding file to processing stack: /Users/ia3andy/workspace/redhat/quarkus/quarkus/devtools/platform-descriptor-json/target/classes/bundled-codestarts/code/resteasy-example/java/src/native-test/java/{package-name.dir}/Native{resource.class-name}IT.tpl.qute.java
DEBUG: found source file: src/main/java/{package-name.dir}/{resource.class-name}.tpl.qute.java
DEBUG: using reader: io.quarkus.devtools.codestarts.reader.QuteCodestartFileReader
DEBUG: adding file to processing stack: /Users/ia3andy/workspace/redhat/quarkus/quarkus/devtools/platform-descriptor-json/target/classes/bundled-codestarts/code/resteasy-example/java/src/main/java/{package-name.dir}/{resource.class-name}.tpl.qute.java
DEBUG: processing file: README.md with strategy: append
DEBUG: processing file: .gitignore with strategy: append
DEBUG: processing file: src/main/resources/application.yml with strategy: smart-config-merge
DEBUG: processing file: pom.xml with strategy: smart-pom-merge
DEBUG: processing file: .dockerignore with strategy: fail-on-duplicate
DEBUG: processing file: src/main/docker/Dockerfile.fast-jar with strategy: fail-on-duplicate
DEBUG: processing file: src/main/docker/Dockerfile.jvm with strategy: fail-on-duplicate
DEBUG: processing file: src/main/docker/Dockerfile.native with strategy: fail-on-duplicate
DEBUG: processing file: mvnw.cmd with strategy: executable
DEBUG: processing file: mvnw with strategy: executable
DEBUG: processing file: src/main/resources/META-INF/resources/index.html with strategy: fail-on-duplicate
DEBUG: processing file: src/test/java/com/test/andy/AndyEndpointTest.java with strategy: fail-on-duplicate
DEBUG: processing file: src/native-test/java/com/test/andy/NativeAndyEndpointIT.java with strategy: native-test-dir-resolve
DEBUG: processing file: src/main/java/com/test/andy/AndyEndpoint.java with strategy: fail-on-duplicate
✅ Applied codestart java (LANGUAGE)
✅ Applied codestart maven (BUILDTOOL)
✅ Applied codestart quarkus (PROJECT)
✅ Applied codestart config-properties (CONFIG)
✅ Applied codestart dockerfiles (TOOLING)
✅ Applied codestart maven-wrapper (TOOLING)
✅ Applied codestart resteasy-example (CODE)
-----------
👍 QUARKUS Project has been successfully generated in:
--> target/codestarts-run-test/project-maven-java-resteasy-example-customized
-----------

gastaldi

I like the emojis, but I think that if message-writer is a new module, it should have its own package (io.quarkus.devtools.messagewriter?)

...nt-projects/tools/message-writer/src/main/java/io/quarkus/devtools/DefaultMessageWriter.java

...endent-projects/tools/codestarts/src/main/java/io/quarkus/devtools/codestarts/Codestart.java

gastaldi

My biggest concern is about the removal of the MessageWriter classes in the platform-descriptor-api. I think we should deprecate them first

...-common/src/main/java/io/quarkus/devtools/commands/handlers/CreateProjectCommandHandler.java

ia3andy · 2020-09-02T13:15:23Z

My biggest concern is about the removal of the MessageWriter classes in the platform-descriptor-api. I think we should deprecate them first

@gastaldi IMO it's ok in a major release, keeping @Deprecated forever as we often do is bad.. @aloubyansky do you think we should keep those as @Deprecated?

if we deprecate, I think we should have a policy and some automation about it to make sure it gets deleted at some point..

gastaldi · 2020-09-02T13:27:28Z

@gastaldi IMO it's ok in a major release, keeping @Deprecated forever as we often do is bad..

I strongly disagree. I'm not saying we should keep it forever (they will be removed at some point), but classes that belong to an API should be initially @deprecated to avoid breakage (that's the whole point of deprecating things really :) )

ia3andy · 2020-09-02T13:35:54Z

@gastaldi IMHO we need to be pragmatic, if this was an api massively used outside of our code, I would agree. But here this is a small tool (not part of the api itself).. I won't argue and @deprecate it, if you really feel unsafe with it.

gastaldi · 2020-09-02T13:39:15Z

I remember using this API outside Quarkus (can't find the sources now). But I'll leave that final decision to @aloubyansky :)

Changes are fine, deprecation needs to be discussed. Leaving that decision to Alexey

ia3andy · 2020-09-02T13:42:24Z

I remember using this API outside Quarkus (can't find the sources now). But I'll leave that final decision to @aloubyansky :)

I mean this isn't public official api, those are internal api for our tooling.

even if it breaks somewhere, well, worst case scenario you look at commit logs and see this was moved
(you add the dep), change the package and you are good to go :) lol

ia3andy · 2020-09-02T13:44:08Z

@maxandersen should we backport this or not?

...ojects/tools/codestarts/src/main/java/io/quarkus/devtools/codestarts/CodestartProcessor.java

aloubyansky · 2020-09-02T14:00:57Z

If you are backporting it you can't break the API. If you are targeting the next minor, you can break it. We've limited the platform compatibility range to a given minor.

aloubyansky

Lambdas as debug args is too much. It looked to me like you could use debug(msg, args) instead.

ia3andy · 2020-09-02T14:24:06Z

Lambdas as debug args is too much. It looked to me like you could use debug(msg, args) instead.

@aloubyansky it is used for "complex" debug logs that requires processing (like list map and join). Don't forget that it is used by code.quarkus.io, I want to avoid the debug unnecessary processing, this is pretty common to provide a lambda for debug logs.. I really feed this is needed as I added a lot of debug logs.

aloubyansky · 2020-09-02T14:32:37Z

Perhaps I missed one, could you point me to the line in this PR where this is justified?

ia3andy · 2020-09-02T14:53:24Z

Perhaps I missed one, could you point me to the line in this PR where this is justified?

Well you are right, there is not such call, I might have removed it in between.. I changed it all to format.

aloubyansky

Thanks. But keep in mind that in case it's backported we need to keep backward compatibility.

Add logs to codestarts

boring-cyborg bot added area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/maven area/platform Issues related to definition and interaction with Quarkus Platform labels Sep 2, 2020

ia3andy changed the title ~~Logging~~ Add some logging to codestarts Sep 2, 2020

ia3andy force-pushed the logging branch 3 times, most recently from 5bec52d to be69952 Compare September 2, 2020 07:42

ia3andy added this to the 1.8.0.CR1 - master milestone Sep 2, 2020

gsmet removed this from the 1.8.0.CR1 - master milestone Sep 2, 2020

ia3andy force-pushed the logging branch from be69952 to fc5ef31 Compare September 2, 2020 09:56

ia3andy marked this pull request as ready for review September 2, 2020 10:12

ia3andy force-pushed the logging branch 2 times, most recently from 0e2c8c9 to f39cbe9 Compare September 2, 2020 12:32

ia3andy requested a review from gastaldi September 2, 2020 12:33

gastaldi requested changes Sep 2, 2020

View reviewed changes

...nt-projects/tools/message-writer/src/main/java/io/quarkus/devtools/DefaultMessageWriter.java Outdated Show resolved Hide resolved

ia3andy force-pushed the logging branch from f39cbe9 to e1c409d Compare September 2, 2020 12:57

ia3andy requested a review from gastaldi September 2, 2020 12:58

gastaldi reviewed Sep 2, 2020

View reviewed changes

...endent-projects/tools/codestarts/src/main/java/io/quarkus/devtools/codestarts/Codestart.java Show resolved Hide resolved

ia3andy force-pushed the logging branch from e1c409d to 6c2f87e Compare September 2, 2020 13:08

gastaldi previously requested changes Sep 2, 2020

View reviewed changes

...-common/src/main/java/io/quarkus/devtools/commands/handlers/CreateProjectCommandHandler.java Show resolved Hide resolved

ia3andy force-pushed the logging branch from 6c2f87e to ff4f96e Compare September 2, 2020 13:26

ia3andy force-pushed the logging branch from ff4f96e to 9272915 Compare September 2, 2020 13:31

gastaldi requested a review from aloubyansky September 2, 2020 13:39

aloubyansky reviewed Sep 2, 2020

View reviewed changes

...ojects/tools/codestarts/src/main/java/io/quarkus/devtools/codestarts/CodestartProcessor.java Outdated Show resolved Hide resolved

aloubyansky requested changes Sep 2, 2020

View reviewed changes

ia3andy force-pushed the logging branch from 9272915 to 3d5d8d9 Compare September 2, 2020 14:52

ia3andy requested a review from aloubyansky September 2, 2020 14:52

aloubyansky approved these changes Sep 2, 2020

View reviewed changes

ia3andy force-pushed the logging branch from 3d5d8d9 to 778c272 Compare September 2, 2020 14:55

Remove codestarts shared-data overrides from example codestarts

a2dbb53

Add logs to codestarts

ia3andy force-pushed the logging branch from 778c272 to a2dbb53 Compare September 2, 2020 15:02

gastaldi added this to the 1.9.0 - master milestone Sep 2, 2020

ia3andy merged commit 970d997 into quarkusio:master Sep 3, 2020

ia3andy deleted the logging branch September 3, 2020 04:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add some logging to codestarts #11803

Add some logging to codestarts #11803

ia3andy commented Sep 2, 2020 •

edited

Loading

ia3andy commented Sep 2, 2020 •

edited

Loading

gastaldi left a comment

gastaldi left a comment

ia3andy commented Sep 2, 2020 •

edited

Loading

gastaldi commented Sep 2, 2020

ia3andy commented Sep 2, 2020

gastaldi commented Sep 2, 2020

ia3andy commented Sep 2, 2020 •

edited

Loading

ia3andy commented Sep 2, 2020

aloubyansky commented Sep 2, 2020

aloubyansky left a comment

ia3andy commented Sep 2, 2020 •

edited

Loading

aloubyansky commented Sep 2, 2020

ia3andy commented Sep 2, 2020

aloubyansky left a comment

Add some logging to codestarts #11803

Add some logging to codestarts #11803

Conversation

ia3andy commented Sep 2, 2020 • edited Loading

ia3andy commented Sep 2, 2020 • edited Loading

gastaldi left a comment

Choose a reason for hiding this comment

gastaldi left a comment

Choose a reason for hiding this comment

ia3andy commented Sep 2, 2020 • edited Loading

gastaldi commented Sep 2, 2020

ia3andy commented Sep 2, 2020

gastaldi commented Sep 2, 2020

ia3andy commented Sep 2, 2020 • edited Loading

ia3andy commented Sep 2, 2020

aloubyansky commented Sep 2, 2020

aloubyansky left a comment

Choose a reason for hiding this comment

ia3andy commented Sep 2, 2020 • edited Loading

aloubyansky commented Sep 2, 2020

ia3andy commented Sep 2, 2020

aloubyansky left a comment

Choose a reason for hiding this comment

ia3andy commented Sep 2, 2020 •

edited

Loading

ia3andy commented Sep 2, 2020 •

edited

Loading

ia3andy commented Sep 2, 2020 •

edited

Loading

ia3andy commented Sep 2, 2020 •

edited

Loading

ia3andy commented Sep 2, 2020 •

edited

Loading