Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed property names in docs where grpc-server was used instead of grpc.server #11877

Merged
merged 1 commit into from
Sep 4, 2020
Merged

fixed property names in docs where grpc-server was used instead of grpc.server #11877

merged 1 commit into from
Sep 4, 2020

Conversation

Shohou
Copy link

@Shohou Shohou commented Sep 4, 2020

Property names in generated "Server configuration" block have dot, while some property mentions have dash. This pull request fixes this

machi1990
machi1990 approved these changes Sep 4, 2020
View reviewed changes
Copy link
Member

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks!

@gsmet gsmet merged commit 09c9e80 into quarkusio:master Sep 4, 2020
@gsmet gsmet modified the milestones: 1.9.0 - master, 1.8.0.Final Sep 4, 2020
@gsmet gsmet modified the milestones: 1.8.0.Final, 1.7.3.Final Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@machi1990 machi1990 machi1990 approved these changes

Assignees
No one assigned
Labels
area/documentation
Projects
None yet
Milestone
1.7.3.Final
Development

Successfully merging this pull request may close these issues.
3 participants
@Shohou @gsmet @machi1990