JSON exporter for Micrometer #11939
Merged
JSON exporter for Micrometer #11939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartisk
force-pushed
the
master-json-exporter
branch
3 times, most recently
from
73d5e13 to
ff7837b
Compare
ebullient
requested changes
Sep 8, 2020
...untime/src/main/java/io/quarkus/micrometer/runtime/binder/mpmetrics/ConcurrentGaugeImpl.java
Outdated
Show resolved
Hide resolved
...time/src/main/java/io/quarkus/micrometer/runtime/binder/mpmetrics/AnnotatedGaugeAdapter.java
Outdated
Show resolved
Hide resolved
.../deployment/src/main/java/io/quarkus/micrometer/deployment/export/JsonRegistryProcessor.java
Show resolved
Hide resolved
| .builder("org.HdrHistogram.Histogram", | ||
| "org.HdrHistogram.DoubleHistogram", | ||
| "org.HdrHistogram.ConcurrentHistogram") | ||
| .constructors(true).build()); |
There was a problem hiding this comment.
Why is reflection necessary for these classes? I'm missing something
There was a problem hiding this comment.
I don't know, but without this, native mode breaks.
...ter/runtime/src/main/java/io/quarkus/micrometer/runtime/registry/json/JsonMeterRegistry.java
Outdated
Show resolved
Hide resolved
...ter/runtime/src/main/java/io/quarkus/micrometer/runtime/registry/json/JsonMeterRegistry.java
Outdated
Show resolved
Hide resolved
jmartisk
force-pushed
the
master-json-exporter
branch
2 times, most recently
from
b624383 to
6af0a4b
Compare
ebullient
reviewed
Sep 9, 2020
...crometer/runtime/src/main/java/io/quarkus/micrometer/runtime/registry/json/JsonExporter.java
Show resolved
Hide resolved
jmartisk
force-pushed
the
master-json-exporter
branch
2 times, most recently
from
f74bb82 to
af13982
Compare
ebullient
reviewed
Sep 16, 2020
...er/runtime/src/main/java/io/quarkus/micrometer/runtime/export/JsonMeterRegistryProvider.java
Show resolved
Hide resolved
ebullient
reviewed
Sep 16, 2020
...ions/micrometer/runtime/src/main/java/io/quarkus/micrometer/runtime/export/JsonRecorder.java
Outdated
Show resolved
Hide resolved
ebullient
reviewed
Sep 16, 2020
...ntime/src/main/java/io/quarkus/micrometer/runtime/registry/json/JsonDistributionSummary.java
Show resolved
Hide resolved
jmartisk
force-pushed
the
master-json-exporter
branch
from
af13982 to
928f180
Compare
|
@ebullient can you confirm everything is OK from your POV? |
kenfinnigan
suggested changes
Sep 22, 2020
...nsions/micrometer/runtime/src/main/java/io/quarkus/micrometer/runtime/config/JsonConfig.java
Show resolved
Hide resolved
...icrometer/runtime/src/main/java/io/quarkus/micrometer/runtime/export/PrometheusRecorder.java
Show resolved
Hide resolved
jmartisk
force-pushed
the
master-json-exporter
branch
from
928f180 to
daab6d4
Compare
kenfinnigan
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.