Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change RedisClientProcessor to singleton #11958

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Change RedisClientProcessor to singleton #11958

merged 1 commit into from
Sep 8, 2020

Conversation

stuartwdouglas
Copy link
Member

ApplicationScoped requires a proxy, and as the class does
not have a no-arg constructor we end up transforming the class
for no real reason.

@stuartwdouglas
Change RedisClientProcessor to singleton
acf1be3 
ApplicationScoped requires a proxy, and as the class does
not have a no-arg constructor we end up transforming the class
for no real reason.
@jaikiran jaikiran requested a review from mkouba September 8, 2020 02:51
mkouba
mkouba approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Singleton is a good match. We could also add a no-args constructor to the class but there is no reason to generate the client proxy anyway...

@mkouba mkouba merged commit b1cccce into quarkusio:master Sep 8, 2020
@machi1990 machi1990 mentioned this pull request Sep 8, 2020
Closed
@gsmet gsmet added this to the 1.9.0 - master milestone Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkouba mkouba mkouba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@stuartwdouglas @mkouba @gsmet