Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArC - distinguish "bean archive" and "additional" index #11980

Merged
merged 1 commit into from
Sep 9, 2020
Merged

ArC - distinguish "bean archive" and "additional" index #11980

merged 1 commit into from
Sep 9, 2020

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Sep 8, 2020

@mkouba
Copy link
Contributor Author

mkouba commented Sep 8, 2020 •
edited
Loading

@38leinaD this PR should fix your problem. It would be great if you could try to test the branch...

@mkouba mkouba requested review from manovotn and geoand September 8, 2020 14:38
@mkouba mkouba added the area/arc Issue related to ARC (dependency injection) label Sep 8, 2020
geoand
geoand reviewed Sep 8, 2020
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine improvement!

I just added some tiny suggestions

@mkouba mkouba marked this pull request as ready for review September 9, 2020 07:35
@mkouba mkouba added this to the 1.9.0 - master milestone Sep 9, 2020
manovotn
manovotn reviewed Sep 9, 2020
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few remarks.

@mkouba mkouba requested a review from manovotn September 9, 2020 10:33
@mkouba
ArC - distinguish "bean archive" and "application" index
8880a95 
- the first one is used to discover components and during type-safe
resolution
- the latter one is also used to discover types during type-safe
resolution
- fixes quarkusio#11863
@mkouba mkouba merged commit 8229f00 into quarkusio:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand left review comments

@manovotn manovotn manovotn approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection)
Projects
None yet
Milestone
1.9.0.CR1
Development

Successfully merging this pull request may close these issues.

Generic Type arguments of producer method needs to be in a bean archive
3 participants
@mkouba @manovotn @geoand