Bootstrap Maven: support for MAVEN_OPTS and properties with whitespaces #12013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gsmet fyi, with this one you won't have to add |
|
@aloubyansky whatever you think is best. Should I close my PR, then? |
|
@metacosm i think so, given that this one covers your issue plus another one. |
gsmet
reviewed
Sep 15, 2020
| for (Object o : userProps.keySet()) { | ||
| String name = o.toString(); | ||
| final String value = userProps.getProperty(name); | ||
| buf.setLength(2); |
There was a problem hiding this comment.
No. What made you question that?
| buf.append(name); | ||
| if (value != null && !value.isEmpty()) { | ||
| buf.append('='); | ||
| buf.append(value); |
There was a problem hiding this comment.
We don't need to escape the values? They will be escaped?
There was a problem hiding this comment.
It should work. This PR includes a devmode test passing a system property with a value containing whitespaces using -D.
gsmet
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11819
Fixes #11467
@metacosm fyi, I took a bit of a different approach here.