Introduce the quarkus.container-image.image property #12070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I won't comment on the code but I think we need the particular GitLab case to be fully documented. |
Yeah that makes sense. I'll do that after I fix the actual test failures :) |
This property is meant to specify the entire image string as one would use on the docker command line or as is found in CI systems like GitLab (whose CI_REGISTRY_IMAGE) was used as a model for this Fixes: quarkusio#8588
Use ContainerImageInfoBuildItem wherever possible instead of using ContainerImageConfig
|
Tests fixed and doc added |
iocanel
approved these changes
Sep 14, 2020
| /** | ||
| * This is basically a simplified version of {@code com.google.cloud.tools.jib.api.ImageReference} | ||
| */ | ||
| public class ImageReference { |
There was a problem hiding this comment.
+1 we might want to replace our ImageUtils with that.
There was a problem hiding this comment.
Good idea!
Let's do that in a follow up. Perhaps the PR you are working on that reworks S2I?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8588
Also, clean up some technical debt related to the container-image extensions.
The handling of the image string and its parts is now much more consistent
between extensions