Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuring the RestAssured timeouts and provide sensible defaults. #12127

Merged
merged 2 commits into from
Sep 17, 2020
Merged

Allow configuring the RestAssured timeouts and provide sensible defaults. #12127

merged 2 commits into from
Sep 17, 2020

Conversation

cescoffier
Copy link
Member

@cescoffier cescoffier commented Sep 16, 2020 •
edited
Loading

Fix #11769.

At the moment, we do not configure the RestAssured timeout. As a consequence, tests can wait up to 45 minutes before failing.

This PR configures the timeout to 30 seconds and provides a way to the user to configure them from the application properties.

@cescoffier
Copy link
Member Author

CC @galderz

machi1990
machi1990 reviewed Sep 16, 2020
View reviewed changes
Copy link
Member

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add something like:

quarkus/core/runtime/src/main/java/io/quarkus/runtime/CommandLineRuntimeConfig.java

Line 10 in 23e1543

* This configuration class is here to avoid warnings when using {@code -Dquarkus.args=...}.

To avoid warnings when quarkus.http.test-timeout is used?

gsmet
gsmet requested changes Sep 16, 2020
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a small suggestion for the doc.

@cescoffier cescoffier force-pushed the configure-restassured-timeout branch from a1b1f49 to 81ab45a Compare September 17, 2020 08:08
@cescoffier
Copy link
Member Author

Thanks @gsmet, merged, and rebased.

@gsmet gsmet merged commit 1c2e688 into quarkusio:master Sep 17, 2020
@gsmet gsmet added this to the 1.9.0 - master milestone Sep 17, 2020
@galderz
Copy link
Member

galderz commented Sep 23, 2020

Thx @cescoffier! 👍

@cescoffier cescoffier deleted the configure-restassured-timeout branch August 1, 2021 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machi1990 machi1990 machi1990 left review comments

@stuartwdouglas stuartwdouglas stuartwdouglas approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/testing
Projects
None yet
Milestone
1.9.0.CR1
Development

Successfully merging this pull request may close these issues.

Rest assured timeouts are way too big
5 participants
@cescoffier @galderz @stuartwdouglas @gsmet @machi1990