Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qute: add basic date-time formatting support #12128

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Qute: add basic date-time formatting support #12128

merged 1 commit into from
Sep 16, 2020

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Sep 16, 2020

@mkouba mkouba added this to the 1.9.0 - master milestone Sep 16, 2020
@mkouba mkouba requested a review from gastaldi September 16, 2020 09:22
@mkouba
Copy link
Contributor Author

mkouba commented Sep 16, 2020

CC @aelfric

gastaldi
gastaldi approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Added a minor suggestion (just for clarification purposes, doesn't change anything really)

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 16, 2020
@gastaldi
Copy link
Contributor

@mkouba thanks for merging my suggestion. Can you squash all commits before merging?

@geoand geoand merged commit 05a4d9f into quarkusio:master Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.9.0.CR1
Development

Successfully merging this pull request may close these issues.

Date and Time Formatting for Qute
3 participants
@mkouba @gastaldi @geoand