Do not rely on svm scope set to provided in the BoM #12138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
<scope>provided</scope>
on everysvm
dependencysvm
dependencies from deployment modules where it is redundantMotivation:
Relying on a
provided
ortest
scope defined in BoM is not necessarily a good practice. People seeingmay naturally expect that the scope is
compile
, but it is not because it is set in the BoM. When people see this in Quarkus they may think thatsvm
should actually have thecompile
scope and they may wrongly copy it in that way to their extension projects. That may lead to bugs like apache/camel-quarkus#1182.I think it is safer for all parties to have an explicit
<scope>provided</scope>
on all places where the dependency is used.