Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes hostAliases property #12288

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Kubernetes hostAliases property #12288

merged 1 commit into from
Sep 24, 2020

Conversation

Vinche59
Copy link
Contributor

Add the possibility to generate hostAliases properties in Kubernetes deployment

Signed-off-by: Vincent Sourtin [email protected]

@gastaldi gastaldi requested review from iocanel and geoand September 23, 2020 14:06
@geoand
Copy link
Contributor

geoand commented Sep 23, 2020

Thanks for this!

I'll leave the review to @iocanel as I assume you have been talking about this?

@geoand geoand added this to the 1.9.0 - master milestone Sep 23, 2020
@Vinche59
Copy link
Contributor Author

Hi @geoand ,
I didn't talk specifically about implementation in quarkus with @iocanel.
I just took inspiration from what already existed :-)

@geoand
Copy link
Contributor

geoand commented Sep 23, 2020

Cool, thanks for your interest!

In any case, I'll have @iocanel have the first say

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few comments.

I also think that we need some tests to ensure this works properly

@Vinche59
Copy link
Contributor Author

Hi @geoand

As requested, I applied your recommendations and add a test to verify the correct generation of kubernetes.yaml with hostaliases directive.
According to you, is this only test is enough or should I add more tests ?

@Vinche59 Vinche59 requested a review from geoand September 23, 2020 21:30
@geoand
Copy link
Contributor

geoand commented Sep 24, 2020

Thanks!

I think the test you added is just fine.

@iocanel mind taking a look at this as well?

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some more small comments

@Vinche59 Vinche59 requested a review from geoand September 24, 2020 08:46
Add the possibility to generate hostAliases properties in Kubernetes deployment

Signed-off-by: Vincent Sourtin <[email protected]>
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks!

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 24, 2020
@gastaldi gastaldi merged commit b360d7c into quarkusio:master Sep 24, 2020
@Vinche59 Vinche59 deleted the k8s-hostaliases branch September 24, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubernetes triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants