-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubernetes hostAliases property #12288
Conversation
Thanks for this! I'll leave the review to @iocanel as I assume you have been talking about this? |
Cool, thanks for your interest! In any case, I'll have @iocanel have the first say |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few comments.
I also think that we need some tests to ensure this works properly
...netes/vanilla/deployment/src/main/java/io/quarkus/kubernetes/deployment/HostAliasConfig.java
Outdated
Show resolved
Hide resolved
Hi @geoand As requested, I applied your recommendations and add a test to verify the correct generation of kubernetes.yaml with hostaliases directive. |
Thanks! I think the test you added is just fine. @iocanel mind taking a look at this as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some more small comments
...netes/vanilla/deployment/src/main/java/io/quarkus/kubernetes/deployment/HostAliasConfig.java
Outdated
Show resolved
Hide resolved
Add the possibility to generate hostAliases properties in Kubernetes deployment Signed-off-by: Vincent Sourtin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thanks!
Add the possibility to generate hostAliases properties in Kubernetes deployment
Signed-off-by: Vincent Sourtin [email protected]