Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove obsolete decorators #12291

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

iocanel
Copy link
Contributor

@iocanel iocanel commented Sep 23, 2020

The pull request removes two decorator implementations that are no longer needed, as ApplicationContainerDecorators can be now used directly even on Objects that have no metadta.

@iocanel
Copy link
Contributor Author

iocanel commented Sep 23, 2020

cc' @metacosm: We recently discussed about this issue, so I thought that you should know.

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you with this :)

@metacosm
Copy link
Contributor

Doesn't this change require a new dekorate version or was that already handled in a previous change?

@iocanel
Copy link
Contributor Author

iocanel commented Sep 23, 2020

We have already upgraded dekorate.

@gastaldi gastaldi added this to the 1.9.0 - master milestone Sep 23, 2020
@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 23, 2020
@machi1990 machi1990 merged commit a60107c into quarkusio:master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubernetes triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants