Defaults for kubernetes mock server #12360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@geoand any thoughts on this one? |
|
I like the idea, but I don't think it should be the default behavior, I would prefer the |
I think this will make tests are easier to read if some entities are not used, but still required.
|
Logic moved to new class EmptyDefaultKubernetesMockServerTestResource and added notes about it in the docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing applications written with the quarkus-kubernetes-client extension, i find that the configuration of kubernetes objects sometimes becomes large very fast and I loose the overview of my tests. Especially, when working with watchers that are registered at application startup.
I propose that we populate the mock server with empty defaults, which the developer can override when needed, instead of giving a 404.
Overriding is still possible with configureMockServer in a subclass, so impact should be neglible, if any.
Alternatively we could also make a new class called something like
KubernetesWatcherMockServerTestResource, which extendsKubernetesMockServerTestResourceand overrideconfigureMockServerthere.