Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add very basic support for command line only applications #1238

Closed
wants to merge 1 commit into from

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Mar 5, 2019

Relates to: #284

This is probably wrong on a few counts since it touches core things that I'm not entirely familiar with.
I'm opening this however with the hope to get some feedback on the approach.

The basic thing the user would use is the CommandLineRunner, similar to what Spring Boot has

Copy link
Member

@dmlloyd dmlloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is the right approach for this kind of application. Let's discuss after the release.

@geoand
Copy link
Contributor Author

geoand commented Mar 6, 2019

I'm not sure this is the right approach for this kind of application. Let's discuss after the release.

This is reason I wanted to open the PR soon - to get feedback :). Feel free to reach out whenever you would like to discuss it

@geoand
Copy link
Contributor Author

geoand commented Mar 6, 2019

I also need to update this based on the new naming for deployment and runtime

@stuartwdouglas
Copy link
Member

Please hold off until after we are done with release as our CI is backed up.

@geoand
Copy link
Contributor Author

geoand commented Mar 6, 2019

Sure thing 👍

@stalep
Copy link
Member

stalep commented Mar 6, 2019

Perhaps Æsh could be a good fit here. Quarkus could provide its own InvocationContext that is sent to the execution block for the command line application. Through the InvocationContext the command line app can automatically get access to whatever API Quarkus wants it to.
Also, Æsh will parse arguments and populate them into appropriate fields.

@geoand
Copy link
Contributor Author

geoand commented Mar 7, 2019

Superseded by #1301

@gsmet gsmet added the triage/out-of-date This issue/PR is no longer valid or relevant label Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/out-of-date This issue/PR is no longer valid or relevant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants