Integrate AzureMonitorRegistry into Micrometer Extension #12448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenfinnigan
approved these changes
Oct 1, 2020
There was a problem hiding this comment.
Looks reasonable to me. Will let @ebullient take a look to make sure I didn't miss anything
|
Just realized, I think we need the commits squashed? Can't recall the exact policy on that. @gsmet? |
ebullient
approved these changes
Oct 1, 2020
|
Please squash the commits, but this is great! Thank you. =) |
squashing the commits and force push? |
|
Please help me! How could the "Quarkus CI / Native Tests - Misc4 (pull_request) fail" it has nothing to do with the changes i made. So i have no clue what to do. |
|
We're working on that one.. something odd is happening w/ the native build. You're correct it has nothing to do with your changes. See #12478 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration of the existing micrometer implementation for Azure Insights Monitor into the quarkus-micrometer extension.