Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set 'Secured' property for Form authentication cookies #12450

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

sberyozkin
Copy link
Member

Fixes #12441

@stuartwdouglas we do not set a same-site cookie in OIDC but only a Secured property, this should resolve the issue as OIDC users have never reported it.
The test does not use HTTPS (I believe it is not possible with RestAssured in Quarkus at the moment), so it just verifies that this property is disabled for non-SSL

@sberyozkin
Copy link
Member Author

This is the error which is reported

Unable to find image 'mariadb:10.4' locally
docker: Error response from daemon: Get https://registry-1.docker.io/v2/library/mariadb/manifests/10.4: received unexpected HTTP status: 500 Internal Server Error.
See 'docker run --help'.
Error: Process completed with exit code 125.

@stuartwdouglas stuartwdouglas merged commit 6ade8c6 into quarkusio:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form based authentication cookie will soon be rejected
2 participants