Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote-dev does not watch config files #12567

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

stuartwdouglas
Copy link
Member

Fixes #12565

@geoand geoand requested a review from aloubyansky October 7, 2020 06:06
@aloubyansky
Copy link
Member

I was just testing it. This does pick up the property updates but there are still issues, e.g. if I add a dependency to the pom I get

2020-10-07 09:20:38,484 ERROR [io.qua.dep.dev.IsolatedRemoteDevModeMain] (main) Failed to generate Quarkus application: java.lang.RuntimeException: remote-dev can only be used with mutable applications generated with the fast-jar format
        at io.quarkus.deployment.dev.IsolatedRemoteDevModeMain.generateApplication(IsolatedRemoteDevModeMain.java:91)
        at io.quarkus.deployment.dev.IsolatedRemoteDevModeMain.accept(IsolatedRemoteDevModeMain.java:199)
        at io.quarkus.deployment.dev.IsolatedRemoteDevModeMain.accept(IsolatedRemoteDevModeMain.java:51)
        at io.quarkus.bootstrap.app.CuratedApplication.runInCl(CuratedApplication.java:129)
        at io.quarkus.bootstrap.app.CuratedApplication.runInAugmentClassLoader(CuratedApplication.java:82)
        at io.quarkus.deployment.dev.DevModeMain.start(DevModeMain.java:144)
        at io.quarkus.deployment.dev.DevModeMain.main(DevModeMain.java:63)

2020-10-07 09:20:38,485 WARN  [io.qua.ver.htt.dep.dev.HttpRemoteDevClientProvider] (main) Live reload URL set but no password, remote dev requires a password, set quarkus.live-reload.password on both server and client
2020-10-07 09:20:38,486 ERROR [io.qua.dep.dev.DevModeMain] (main) Quarkus dev mode failed to start: java.lang.RuntimeException: java.lang.RuntimeException: java.util.NoSuchElementException: No value present
        at io.quarkus.bootstrap.app.CuratedApplication.runInCl(CuratedApplication.java:132)
        at io.quarkus.bootstrap.app.CuratedApplication.runInAugmentClassLoader(CuratedApplication.java:82)
        at io.quarkus.deployment.dev.DevModeMain.start(DevModeMain.java:144)
        at io.quarkus.deployment.dev.DevModeMain.main(DevModeMain.java:63)
Caused by: java.lang.RuntimeException: java.util.NoSuchElementException: No value present
        at io.quarkus.deployment.dev.IsolatedRemoteDevModeMain.accept(IsolatedRemoteDevModeMain.java:221)
        at io.quarkus.deployment.dev.IsolatedRemoteDevModeMain.accept(IsolatedRemoteDevModeMain.java:51)
        at io.quarkus.bootstrap.app.CuratedApplication.runInCl(CuratedApplication.java:129)
        ... 3 more
Caused by: java.util.NoSuchElementException: No value present
        at java.base/java.util.Optional.get(Optional.java:148)
        at io.quarkus.vertx.http.deployment.devmode.HttpRemoteDevClientProvider.getClient(HttpRemoteDevClientProvider.java:34)
        at io.quarkus.deployment.dev.IsolatedRemoteDevModeMain.createClient(IsolatedRemoteDevModeMain.java:72)
        at io.quarkus.deployment.dev.IsolatedRemoteDevModeMain.accept(IsolatedRemoteDevModeMain.java:205)
        ... 5 more

Exception in thread "main" java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.util.NoSuchElementException: No value present
        at io.quarkus.deployment.dev.DevModeMain.start(DevModeMain.java:150)
        at io.quarkus.deployment.dev.DevModeMain.main(DevModeMain.java:63)
Caused by: java.lang.RuntimeException: java.lang.RuntimeException: java.util.NoSuchElementException: No value present
        at io.quarkus.bootstrap.app.CuratedApplication.runInCl(CuratedApplication.java:132)
        at io.quarkus.bootstrap.app.CuratedApplication.runInAugmentClassLoader(CuratedApplication.java:82)
        at io.quarkus.deployment.dev.DevModeMain.start(DevModeMain.java:144)
        ... 1 more
Caused by: java.lang.RuntimeException: java.util.NoSuchElementException: No value present
        at io.quarkus.deployment.dev.IsolatedRemoteDevModeMain.accept(IsolatedRemoteDevModeMain.java:221)
        at io.quarkus.deployment.dev.IsolatedRemoteDevModeMain.accept(IsolatedRemoteDevModeMain.java:51)
        at io.quarkus.bootstrap.app.CuratedApplication.runInCl(CuratedApplication.java:129)
        ... 3 more
Caused by: java.util.NoSuchElementException: No value present
        at java.base/java.util.Optional.get(Optional.java:148)
        at io.quarkus.vertx.http.deployment.devmode.HttpRemoteDevClientProvider.getClient(HttpRemoteDevClientProvider.java:34)
        at io.quarkus.deployment.dev.IsolatedRemoteDevModeMain.createClient(IsolatedRemoteDevModeMain.java:72)
        at io.quarkus.deployment.dev.IsolatedRemoteDevModeMain.accept(IsolatedRemoteDevModeMain.java:205)
        ... 5 more

@aloubyansky
Copy link
Member

It does not fail every time but often enough though.

@aloubyansky
Copy link
Member

That's a separate issue though. I'll open another one for it. Thanks @stuartwdouglas

@aloubyansky aloubyansky merged commit 93b61a1 into quarkusio:master Oct 7, 2020
@gsmet gsmet added this to the 1.9.0.CR1 milestone Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remote-dev is not taking into account HotDeploymentWatchedFileBuildItem
3 participants