Made JarResult.originalArtifact point to the actual original jar instead of where it should end up after renaming #13259
Conversation
…ead of where it should end up after renaming
ghost
added
area/core
area/devtools
| @@ -140,7 +140,6 @@ | |||
| public static final String APP = "app"; | |||
| public static final String QUARKUS = "quarkus"; | |||
| public static final String DEFAULT_FAST_JAR_DIRECTORY_NAME = "quarkus-app"; | |||
| public static final String RENAMED_JAR_EXTENSION = ".jar.original"; | |||
There was a problem hiding this comment.
@mariofusco @evacchi i am not sure it is relevant for you but given that @mariofusco introduced this constant i wanted to check whether removing it is ok.
There was a problem hiding this comment.
I only found this reference in a comment but I honestly don't even know if it's still relevant https://github.com/kiegroup/kogito-runtimes/blob/bece507d15db8b3270d4d35408b29ec34dffc1de/kogito-quarkus-extension/deployment/src/main/java/org/kie/kogito/quarkus/deployment/AppPaths.java#L132 @mariofusco
There was a problem hiding this comment.
So it looks like it's even better. With this change it will always be jar.
That's the intended outcome for now. If you build with |
|
@gsmet do you want me to squash it all? |
This fixes an issue when building the uber-jar runner the target dir ends up containing the uber runner jar, the original jar and the "xxx.jar.original" directory which is a copy of the classes dir.