Handle default package name when generating class names

[maxandersen]

Fixes #13540

Replaced all occurrences of targetPackage.replace('.', '/') + "/" + baseName
with (targetPackage.isEmpty() ? "" : targetPackage.replace('.', '/') + "/") + baseName
to avoid generating file names that goes to the root (/) of the file system.

[mkouba]

We could create some util method/class that could be used for all occurences except the ValueResolverGenerator which is an indepenent project.

We should probably also add some tests, something similar to https://github.com/quarkusio/quarkus/blob/master/extensions/arc/deployment/src/test/java/SingleLetterDefaultPackageTest.java.

[maxandersen]

We could create some util method/class that could be used for all occurences except the ValueResolverGenerator which is an indepenent project.

I agree it would be nice with a utility method; with this we are porbably at like 10+ changes we discovered it.

[stuartwdouglas]

I wonder if we can just address this at a lower level:

• Make Gizmo strip a leading '/' from a class name
• Strip a leading '/' from file resources that are generated
  I think this should make this no longer an issue

[maxandersen]

@stuartwdouglas your choice :)

for now I've updated the PR to be rebased against latest master.

[maxandersen]

We should probably also add some tests, something similar to master/extensions/arc/deployment/src/test/java/SingleLetterDefaultPackageTest.java.

I agree we should add some but I would rather put those into some jbang tests in a separate PR if thats okey.

[mkouba]

We should probably also add some tests, something similar to master/extensions/arc/deployment/src/test/java/SingleLetterDefaultPackageTest.java.

I agree we should add some but I would rather put those into some jbang tests in a separate PR if thats okey.

It's OK. However, I would still prefer something like io.quarkus.deployment.util.Packages#getInternalForm(String packageName) ;-).

[gsmet]

I'm closing this one, it doesn't compile and looks like we might want to pursue a different path.

Please open a new one once things are sorted out.

[stuartwdouglas]

I have opened #14839