Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Kubernetes Client to 5.x #13775

Merged
merged 1 commit into from
Dec 30, 2020
Merged

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Dec 9, 2020

No description provided.

@ghost ghost added area/dependencies Pull requests that update a dependency file area/kubernetes labels Dec 9, 2020
@geoand geoand marked this pull request as ready for review December 9, 2020 19:26
@gsmet
Copy link
Member

gsmet commented Dec 14, 2020

Rebased and squashed.

@geoand @maxandersen is it something we want in Beta1?

@geoand
Copy link
Contributor Author

geoand commented Dec 14, 2020

I think we can wait - doesn't need to be Beta1

@rsvoboda
Copy link
Member

I this going to be in Quarkus 1.11?

Another concern is 5.0.0-alpha-3 version of the client, when is .Final planned for it?

@geoand
Copy link
Contributor Author

geoand commented Dec 14, 2020

Exactly, I wanted to wait for a non-alpha version as well.

@manusa any idea?

@manusa
Copy link
Contributor

manusa commented Dec 14, 2020

Exactly, I wanted to wait for a non-alpha version as well.

@manusa any idea?

We're almost done with the features for this milestone. @metacosm is still trying to add some improvements regarding experience with Custom Resources.
We're starting to check if everything is OK after upgrading some of our dependent projects too.

The idea is to release final version before 2021-01-06 so it can be part of 1.11. Is this deadline OK? Or should we aim for a sooner date?

@geoand
Copy link
Contributor Author

geoand commented Dec 14, 2020

The idea is to release final version before 2021-01-06 so it can be part of 1.11. Is this deadline OK? Or should we aim for a sooner date?

Thanks for the info!

I'll let @gsmet and @rsvoboda answer about the deadline.

@rsvoboda
Copy link
Member

https://github.com/quarkusio/quarkus/wiki/Release-Planning says "Core CR1 on January 6th".

So your plan to release on January 6th is quite tight and there is no community bake time for this upgrade.
That concerns me, as 1.11 is important from prod perspective.

@manusa
Copy link
Contributor

manusa commented Dec 14, 2020

Aim is/was to release before January 6th. However, it would be good to know what would be a desirable specific target date (from Quarkus perspective) to be able to make it into the 1.11 CR. Or if we should target 1.12 instead.

As I said, most of what we wanted to include in this version is ready, an earlier release is very much doable. We want to make sure nothing is broken, our main effort right now is in testing.

@rsvoboda
Copy link
Member

Guillaume is going to release 1.11.0.Beta1 later this week, it would be good to have what's ready included in the build to get some feedback. @gsmet wdyt?

@gsmet
Copy link
Member

gsmet commented Dec 14, 2020

Beta1 is not here to put more pressure on everyone but to offer the opportunity for some teams to get some feedback early.

I'm fine with a Kubernetes Client upgrade in CR1. Just to be precise: January 6th is the release day so the PR needs to be merged the day before.

@maxandersen
Copy link
Member

Let's give Kubernetes client the time it needs to get to cr state. It's already on a tight schedule.

@manusa
Copy link
Contributor

manusa commented Dec 15, 2020

If we cut a 5.0.0-rc-1 (CR), would that make it into the Beta.1? If so, when would we need to provide this release candidate version ("later this week")?

@gsmet
Copy link
Member

gsmet commented Dec 15, 2020

@manusa I would need the update to be merged in Quarkus by tomorrow evening.

Again, there's no need to rush if it's not ready.

@manusa
Copy link
Contributor

manusa commented Dec 15, 2020

@manusa I would need the update to be merged in Quarkus by tomorrow evening.

Again, there's no need to rush if it's not ready.

Great thanks. It surely is tight. I'll ping you folks in the unlikely event that things go very well and we manage to release in the morning.

@manusa
Copy link
Contributor

manusa commented Dec 22, 2020

Hi @geoand / @gastaldi (not sure who is maintaining this PR)

I cut v5.0.0-beta-1 yesterday.
We'll be updating our dependent projects with this new version to see everything is still working. We're also starting to thoroughly check nothing was broken. The plan is to release once we made sure everything is OK (< 2021-01-05).

I hope we're still on track for 1.11.

@geoand
Copy link
Contributor Author

geoand commented Dec 22, 2020

Thanks @manusa!

PR updated

@manusa
Copy link
Contributor

manusa commented Dec 30, 2020

I was coming by to let you know that we just cut 5.0.0, but George was quicker ;)

Don't know how do you want to proceed with the migration guide (https://groups.google.com/g/quarkus-dev/c/G96XwoUdUug/m/If8DnkWdBQAJ). I'm happy to help in any way I can.

@gastaldi
Copy link
Contributor

@manusa I updated the Quarkus migration guide with a link to the Kubernetes Client migration guide: https://github.com/quarkusio/quarkus/wiki/Migration-Guide-1.11#kubernetes-client

@manusa
Copy link
Contributor

manusa commented Dec 30, 2020

👍 great, thx!

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 30, 2020
@gastaldi gastaldi merged commit 8ce16d7 into quarkusio:master Dec 30, 2020
@ghost ghost added this to the 1.11 - master milestone Dec 30, 2020
@gastaldi gastaldi deleted the k8s-client-5.x branch December 30, 2020 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/kubernetes release/breaking-change triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants