-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Kubernetes Client to 5.x #13775
Conversation
aeb286f
to
5ced767
Compare
30ecb5a
to
a762535
Compare
Rebased and squashed. @geoand @maxandersen is it something we want in Beta1? |
I think we can wait - doesn't need to be Beta1 |
I this going to be in Quarkus 1.11? Another concern is |
Exactly, I wanted to wait for a non-alpha version as well. @manusa any idea? |
We're almost done with the features for this milestone. @metacosm is still trying to add some improvements regarding experience with Custom Resources. The idea is to release final version before 2021-01-06 so it can be part of 1.11. Is this deadline OK? Or should we aim for a sooner date? |
https://github.com/quarkusio/quarkus/wiki/Release-Planning says "Core CR1 on January 6th". So your plan to release on January 6th is quite tight and there is no community bake time for this upgrade. |
Aim is/was to release before January 6th. However, it would be good to know what would be a desirable specific target date (from Quarkus perspective) to be able to make it into the 1.11 CR. Or if we should target 1.12 instead. As I said, most of what we wanted to include in this version is ready, an earlier release is very much doable. We want to make sure nothing is broken, our main effort right now is in testing. |
Guillaume is going to release 1.11.0.Beta1 later this week, it would be good to have what's ready included in the build to get some feedback. @gsmet wdyt? |
Beta1 is not here to put more pressure on everyone but to offer the opportunity for some teams to get some feedback early. I'm fine with a Kubernetes Client upgrade in CR1. Just to be precise: January 6th is the release day so the PR needs to be merged the day before. |
Let's give Kubernetes client the time it needs to get to cr state. It's already on a tight schedule. |
If we cut a 5.0.0-rc-1 (CR), would that make it into the Beta.1? If so, when would we need to provide this release candidate version ("later this week")? |
@manusa I would need the update to be merged in Quarkus by tomorrow evening. Again, there's no need to rush if it's not ready. |
Great thanks. It surely is tight. I'll ping you folks in the unlikely event that things go very well and we manage to release in the morning. |
Hi @geoand / @gastaldi (not sure who is maintaining this PR) I cut v5.0.0-beta-1 yesterday. I hope we're still on track for 1.11. |
a762535
to
d028be8
Compare
Thanks @manusa! PR updated |
I was coming by to let you know that we just cut 5.0.0, but George was quicker ;) Don't know how do you want to proceed with the migration guide (https://groups.google.com/g/quarkus-dev/c/G96XwoUdUug/m/If8DnkWdBQAJ). I'm happy to help in any way I can. |
@manusa I updated the Quarkus migration guide with a link to the Kubernetes Client migration guide: https://github.com/quarkusio/quarkus/wiki/Migration-Guide-1.11#kubernetes-client |
👍 great, thx! |
d028be8
to
d9240bb
Compare
No description provided.