Deactivate logs from SqlExceptionHelper #13854
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly done to prevent duplicate logs. SqlExceptionHelper's logger logs the cause and sql state from the sqlexception, which most often also appear in the getMessage of the sqlexception itself. The applications logger will log them anyway.
ghost
added
area/hibernate-orm
emretanriverdi
approved these changes
Jan 7, 2021
|
@Sanne WDYT about this one? |
|
sorry for having missed it. I'm not sure about this, as this removes the SQL Error code which seems rather useful to have. @Postremus do you have an example stacktrace that highlights what's annoying about this? How comfortable are you that you won't need the extra information this adds? Finally, if you think this is too noisy, shouldn't we rather improve Hibernate ORM 's logging? |
|
Is there also an issue of warnings vs exceptions in this? IIRC we log SQL warnings instead of just ignoring them. |
|
As @Sanne pointed out, this removes the SQL Error code which seems rather useful to have, therefore I'm closing this PR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done to prevent duplicate logs.
SqlExceptionHelper logs the cause and sql state from the given, and all underlying, SQLExceptions. These already appear as part of the original exceptions getMessage().
Related to #13776.