-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to start the Quartz scheduler in halted mode #14122
Conversation
extensions/quartz/deployment/src/test/java/io/quarkus/quartz/test/HaltedScheduleJobTest.java
Outdated
Show resolved
Hide resolved
extensions/quartz/deployment/src/test/java/io/quarkus/quartz/test/HaltedScheduleJobTest.java
Outdated
Show resolved
Hide resolved
extensions/quartz/deployment/src/test/java/io/quarkus/quartz/test/HaltedScheduleJobTest.java
Outdated
Show resolved
Hide resolved
extensions/quartz/runtime/src/main/java/io/quarkus/quartz/runtime/QuartzScheduler.java
Outdated
Show resolved
Hide resolved
@mkouba I applied your suggestions and renamed |
@gsmet (note) not to be confused with quartz standby mode (which can affect behavior on resuming a trigger) |
@nragon so you're saying renaming it to From my tests, the Quartz scheduler was in standby mode on startup. |
Hm, that's actually a good point. So By the way, the current |
It's paused by default (until started): https://github.com/quartz-scheduler/quartz/blob/master/quartz-core/src/main/java/org/quartz/core/QuartzSchedulerThread.java#L123 |
Not sure I understand that? |
Went back to |
Yeah, it works because |
I was just mentioning that the standby action on quartz implies notifying both job store and listeners. |
@nragon yes, makes sense. I went back to your original proposal, sorry for the noise. |
Supersedes #14043
/cc @nragon @machi1990