Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support OIDC cookie-path-header and storing id and refresh tokens #14227

Merged
merged 1 commit into from
Jan 12, 2021
Merged

Support OIDC cookie-path-header and storing id and refresh tokens #14227

merged 1 commit into from
Jan 12, 2021

Conversation

sberyozkin
Copy link
Member

Fixes #14189
Fixes #13485

This PR:

  • Makes it possible to use the headers such as X-Forwarded-Prefix to set a cookie path. This is important in the cases where unique SSO sessions/applications are managed with the same domain, such as example.org/app1 and example.org/app2
  • Added a missing ID + Refresh default token strategy - this should be recommended for all the cases where the access token is not required - which is likely to be 70-80% cases
  • tests and docs have been updated

@sberyozkin sberyozkin added this to the 1.12 - master milestone Jan 11, 2021
gastaldi
gastaldi requested changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments and found some minor typos. Looks good overall

@sberyozkin sberyozkin force-pushed the oidc_cookie_improvements branch from 48ba32b to 73a5024 Compare January 11, 2021 17:26
@sberyozkin
Copy link
Member Author

@pedroigor thanks Pedro, @gastaldi are you OK now with the applied changes ?

gastaldi
gastaldi approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, LGTM. Good job 😉

@sberyozkin
Copy link
Member Author

@gastaldi without you the security docs would not be a joy to read :-).

@sberyozkin sberyozkin merged commit d0ed9c6 into quarkusio:master Jan 12, 2021
@sberyozkin sberyozkin deleted the oidc_cookie_improvements branch January 12, 2021 11:47
@gastaldi
Copy link
Contributor

@sberyozkin thank you but you are the one writing the text, I am just watching for typos ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

@pedroigor pedroigor pedroigor approved these changes

Assignees
No one assigned
Labels
area/documentation area/oidc
Projects
None yet
Milestone
1.12.0.CR1
3 participants
@sberyozkin @gastaldi @pedroigor