Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Dotname instead of Type to determine @BeanParam class target #14356

Merged
merged 1 commit into from
Jan 18, 2021
Merged

Use Dotname instead of Type to determine @BeanParam class target #14356

merged 1 commit into from
Jan 18, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jan 18, 2021 •
edited
Loading

Fixes: #14348

@ghost ghost added the area/rest label Jan 18, 2021
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 18, 2021
FroMage
FroMage approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch.

@geoand
Copy link
Contributor Author

geoand commented Jan 18, 2021

I've seen this before in other contexts :).

These stringly types APIs can cause significant headaches :P

@gsmet
Copy link
Member

gsmet commented Jan 18, 2021

I think the only way to get rid of these mistakes is to use forbiddenapis. We could ban this altogether as there's no good reason to call this.

@geoand
Copy link
Contributor Author

geoand commented Jan 18, 2021

Indeed, there is no good reason I can think of to call toString on Type

@geoand geoand merged commit f60af75 into quarkusio:master Jan 18, 2021
@ghost ghost added this to the 1.12 - master milestone Jan 18, 2021
@geoand geoand deleted the #14348 branch January 18, 2021 12:04
@gsmet gsmet modified the milestones: 1.12 - master, 1.11.1.Final Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

@FroMage FroMage FroMage approved these changes

Assignees
No one assigned
Labels
area/rest triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.11.1.Final
Development

Successfully merging this pull request may close these issues.

Resteasy Reactive - stream cannot be null
4 participants
@geoand @gsmet @gastaldi @FroMage