Set quarkus.datasource.db-kind automatically K8S Service Binding is used #14393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
requested changes
Jan 19, 2021
extensions/agroal/spi/src/main/java/io/quarkus/agroal/spi/DefaultDataSourceDbKindBuildItem.java
Outdated
Show resolved
Hide resolved
.../deployment/src/main/java/io/quarkus/jdbc/postgresql/deployment/JDBCPostgreSQLProcessor.java
Show resolved
Hide resolved
geoand
force-pushed
the
#14327
branch
2 times, most recently
from
452caf9 to
a84605c
Compare
ghost
added
the
geoand
commented
Jan 20, 2021
| import io.quarkus.test.junit.QuarkusTest; | ||
|
|
||
| @QuarkusTest | ||
| public class FruitsEndpointTest { |
There was a problem hiding this comment.
I purposely don't have a native test for this as the service binding code does not do anything that would prevent it from working in native
|
@gsmet ping :) |
|
#14393 also needs to be figured out after this one |
gsmet
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is that when the service binding extensions is used along with a quarkus driver, we can automatically pick the database kind.
This relieves the user from having to configure anything datasource specific in their
application properties.Relates to: #14327